-
Notifications
You must be signed in to change notification settings - Fork 767
bump: v1.11.8 #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: v1.11.8 #1843
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ import tag from "html-tag-js"; | |
| import helpers from "utils/helpers"; | ||
| import Path from "utils/Path"; | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization. Prompt To Fix With AIThis is a comment left during a code review.
Path: src/components/fileTree/index.js
Line: 7:7
Comment:
Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.
How can I resolve this? If you propose a fix, please make it concise. |
||
| const VIRTUALIZATION_THRESHOLD = 100; | ||
| const VIRTUALIZATION_THRESHOLD = Number.POSITIVE_INFINITY; // FIX: temporary due to some scrolling issues in VirtualList | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disabling virtualization by setting It's strongly recommended to create a technical debt ticket to track this issue and ensure that the underlying scrolling problem in |
||
| const ITEM_HEIGHT = 30; | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog contains several entries that don't follow the conventional commit format (
type(scope): message). This makes the changelog less consistent and harder to parse automatically. Please consider rephrasing them to improve consistency.For example:
Added testscould betest: add initial test suiteor something more descriptive.CustomTabs web api for pluginscould befeat: add CustomTabs web API for plugins.Refactor quicktools settingscould berefactor: refactor quicktools settings.Fix:should be lowercasefix:.