Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,74 @@
# Change Log

## v1.11.8 (967)

### Features
* feat: add acode cli by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1768
* feat: Add FileTree component with virtual scrolling by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1774
* feat(welcome): add welcome tab for first-time users by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1783
* feat: Add visibility toggle for quicktools toggler on terminal input by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1766
* feat: Add smart path shortening to terminal prompt by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1767
* feat(settings): add option to preserve original item order by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1772
* feat: add "Open in Terminal" option to folder context menu by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1809
* feat: add proper fallback and saf uri handling for ischeck by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1814
* feat: extensionless URL resolution in preview server by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1824
* feat: improve DevContainer and Docker support for easier dev setup by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1823
* feat: add eruda devtools for debugging by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1831
* feat: Refactor li-icon set and add new icon by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1759
* feat: Enhance `addIcon` to support svg currentColor by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1760
* feat: Offload file change detection to background thread by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1802
* feat: move service to background by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1754
* feat: add quiet hours for ads by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1779
* feat(auth): move authentication to native Android plugin with encrypted storage by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1794
* feat: do not close milestone issues by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1799
* feat: close search dialog with ctrl+f by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1807
* feat: added executor tests by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1816
* Added tests by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1813
* CustomTabs web api for plugins by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1785
* Implement plugin loading callbacks and tracking for installed plugins by @7HR4IZ3 in https://github.com/Acode-Foundation/Acode/pull/1558
* Added Documents viewer plugin id to load pdf/excel/csv etc. files by @hackesofice in https://github.com/Acode-Foundation/Acode/pull/1833
* Refactor quicktools settings by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1761

### Fixes
* fix: use correct timezone by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1716
* fix: sanitize plugin readme before rendering by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1731
* fix: make rm wrapper silent by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1727
* fix: remove duplicate rm command by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1732
* fix: sidebar app icon size and scrolling by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1733
* fix: terminal bug by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1741
* fix: sidebar apps active and removal things with fallback by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1749
* fix: improve the backup and restore by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1744
* fix: console by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1763
* fix(terminal): cleanup broken tabs and show alerts on terminal errors by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1780
* fix(plugin): sanitize markdown and prevent horizontal overflow by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1782
* fix: run current File not respecting `preview mode` option. by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1805
* fix: memory leak when toggling search panel by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1808
* fix: prevent mixed content in SFTP/FTP cached files by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1815
* Fix: Remove trimming of matched content in Executor.js by @dikidjatar in https://github.com/Acode-Foundation/Acode/pull/1798
Comment on lines +26 to +47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog contains several entries that don't follow the conventional commit format (type(scope): message). This makes the changelog less consistent and harder to parse automatically. Please consider rephrasing them to improve consistency.

For example:

  • Line 26: Added tests could be test: add initial test suite or something more descriptive.
  • Line 27: CustomTabs web api for plugins could be feat: add CustomTabs web API for plugins.
  • Line 30: Refactor quicktools settings could be refactor: refactor quicktools settings.
  • Line 47: Fix: should be lowercase fix:.

* revert: relative http paths by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1743

### Chore & CI
* Add F-droid Build in GH nightly releases by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1719
* fix(CI): normal nightly & fdroid flavor build paths. by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1722
* Update devcontainer.json and add Dependabot for devcontainer's version updates by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1742
* enhance nightly build workflow by adding a step to generate release notes by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1747
* chore: update nightly build workflow to use a fine-grained GITHUB_TOKEN for generating nightly release notes by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1751
* chore: message type detection in release notes script by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1786
* update(sftp): dependencies for SFTP plugin by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1792
* chore(deps): bump tmp and cordova by @dependabot[bot] in https://github.com/Acode-Foundation/Acode/pull/1720
* chore(deps): bump tough-cookie and cordova by @dependabot[bot] in https://github.com/Acode-Foundation/Acode/pull/1721
* chore(deps): bump systeminformation from 5.27.11 to 5.27.14 by @dependabot[bot] in https://github.com/Acode-Foundation/Acode/pull/1750
* chore(deps): bump tar from 7.5.2 to 7.5.3 by @dependabot[bot] in https://github.com/Acode-Foundation/Acode/pull/1829

### Translations & i18n
* `pl-pl.json` by @andrewczm in https://github.com/Acode-Foundation/Acode/pull/1709
* `de-de.json` by @Mr-Update in https://github.com/Acode-Foundation/Acode/pull/1714, https://github.com/Acode-Foundation/Acode/pull/1764
* `cs-cz.json` by @Amereyeu in https://github.com/Acode-Foundation/Acode/pull/1752, https://github.com/Acode-Foundation/Acode/pull/1828
* `hu-hu.json` by @summoner001 in https://github.com/Acode-Foundation/Acode/pull/1755, https://github.com/Acode-Foundation/Acode/pull/1762, https://github.com/Acode-Foundation/Acode/pull/1787, https://github.com/Acode-Foundation/Acode/pull/1810, https://github.com/Acode-Foundation/Acode/pull/1834
* `zh-cn.json`, `zh-hant.json` by @LaunchLee in https://github.com/Acode-Foundation/Acode/pull/1769
* `pt-br.json` by @sebastianjnuwu in https://github.com/Acode-Foundation/Acode/pull/1775
* `uk-ua.json` by @PavloPogonets in https://github.com/Acode-Foundation/Acode/pull/1818, https://github.com/Acode-Foundation/Acode/pull/1821

## v1.11.7 (966)

* revert: sidebar/style.scss changes to fix collapse folders by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1572
Expand Down
2 changes: 1 addition & 1 deletion config.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8' ?>
<widget id="com.foxdebug.acode" android-versionCode="966" version="1.11.7"
<widget id="com.foxdebug.acode" android-versionCode="967" version="1.11.8"
xmlns="http://www.w3.org/ns/widgets"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:cdv="http://cordova.apache.org/ns/1.0">
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "com.foxdebug.acode",
"displayName": "Acode",
"version": "1.11.7",
"version": "1.11.8",
"description": "Acode is a code editor for android",
"scripts": {
"lang": "node ./utils/lang.js",
Expand Down
2 changes: 1 addition & 1 deletion src/components/fileTree/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import tag from "html-tag-js";
import helpers from "utils/helpers";
import Path from "utils/Path";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/fileTree/index.js
Line: 7:7

Comment:
Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.

How can I resolve this? If you propose a fix, please make it concise.

const VIRTUALIZATION_THRESHOLD = 100;
const VIRTUALIZATION_THRESHOLD = Number.POSITIVE_INFINITY; // FIX: temporary due to some scrolling issues in VirtualList
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling virtualization by setting VIRTUALIZATION_THRESHOLD to Infinity can lead to significant performance degradation when rendering directories with a large number of files. While the comment indicates this is a temporary fix for scrolling issues, it's a critical performance feature being disabled.

It's strongly recommended to create a technical debt ticket to track this issue and ensure that the underlying scrolling problem in VirtualList is addressed and virtualization is re-enabled. Leaving this as-is could negatively impact user experience for those with large projects.

const ITEM_HEIGHT = 30;

/**
Expand Down
14 changes: 7 additions & 7 deletions src/lang/uk-ua.json
Original file line number Diff line number Diff line change
Expand Up @@ -222,25 +222,25 @@
"download acode pro": "Завантажити Acode pro",
"loading plugins": "Завантаження плагінів",
"faqs": "FAQs",
"feedback": "Зворотний зв'язок",
"feedback": "Зворотний зв'язок",
"header": "Заголовок",
"sidebar": "Бічна панель",
"inapp": "У додатку",
"browser": "Браузер",
"diagonal scrolling": "Діагональне прокручування",
"reverse scrolling": "Зворотне прокручування",
"formatter": "Форматувальник",
"format on save": "Форматування при збереженні",
"format on save": "Форматування при збереженні",
"remove ads": "Видалити рекламу",
"fast": "Швидко",
"slow": "Повільно",
"scroll settings": "Налаштування прокручування",
"scroll speed": "Швидкість прокручування",
"scroll settings": "Налаштування прокручування",
"scroll speed": "Швидкість прокручування",
"loading...": "Завантаження...",
"no plugins found": "Плагіни не знайдені",
"name": "Ім'я",
"username": "Ім'я користувача",
"optional": "Опціонально",
"optional": "Опціонально",
"hostname": "Ім'я хоста",
"password": "Пароль",
"security type": "Тип безпеки",
Expand Down Expand Up @@ -326,7 +326,7 @@
"owned": "Owned",
"api_error": "API server down, please try after some time.",
"installed": "Встановлено",
"all": "Усі",
"all": "Усі",
"medium": "Medium",
"refund": "Refund",
"product not available": "Product not available",
Expand Down Expand Up @@ -397,7 +397,7 @@
"show side buttons": "Show side buttons",
"bug_report": "Надіслати звіт про помилку",
"verified publisher": "Verified publisher",
"most_downloaded": "Найбільш завантажувані",
"most_downloaded": "Найбільш завантажувані",
"newly_added": "Нещодавно додані",
"top_rated": "Top Rated",
"rename not supported": "Rename on termux dir isn't supported",
Expand Down