-
Notifications
You must be signed in to change notification settings - Fork 767
bump: v1.11.8 #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: v1.11.8 #1843
Conversation
Summary of ChangesHello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily serves as a version bump to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version to v1.11.8. The changes include updating the version in configuration files, adding a comprehensive changelog, and a temporary fix to disable virtualization in the file tree component. My review focuses on improving the consistency of the changelog and highlighting the performance implications of disabling virtualization, with a recommendation to track this as technical debt.
| import Path from "utils/Path"; | ||
|
|
||
| const VIRTUALIZATION_THRESHOLD = 100; | ||
| const VIRTUALIZATION_THRESHOLD = Number.POSITIVE_INFINITY; // FIX: temporary due to some scrolling issues in VirtualList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling virtualization by setting VIRTUALIZATION_THRESHOLD to Infinity can lead to significant performance degradation when rendering directories with a large number of files. While the comment indicates this is a temporary fix for scrolling issues, it's a critical performance feature being disabled.
It's strongly recommended to create a technical debt ticket to track this issue and ensure that the underlying scrolling problem in VirtualList is addressed and virtualization is re-enabled. Leaving this as-is could negatively impact user experience for those with large projects.
| * Added tests by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1813 | ||
| * CustomTabs web api for plugins by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1785 | ||
| * Implement plugin loading callbacks and tracking for installed plugins by @7HR4IZ3 in https://github.com/Acode-Foundation/Acode/pull/1558 | ||
| * Added Documents viewer plugin id to load pdf/excel/csv etc. files by @hackesofice in https://github.com/Acode-Foundation/Acode/pull/1833 | ||
| * Refactor quicktools settings by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1761 | ||
|
|
||
| ### Fixes | ||
| * fix: use correct timezone by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1716 | ||
| * fix: sanitize plugin readme before rendering by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1731 | ||
| * fix: make rm wrapper silent by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1727 | ||
| * fix: remove duplicate rm command by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1732 | ||
| * fix: sidebar app icon size and scrolling by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1733 | ||
| * fix: terminal bug by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1741 | ||
| * fix: sidebar apps active and removal things with fallback by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1749 | ||
| * fix: improve the backup and restore by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1744 | ||
| * fix: console by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1763 | ||
| * fix(terminal): cleanup broken tabs and show alerts on terminal errors by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1780 | ||
| * fix(plugin): sanitize markdown and prevent horizontal overflow by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1782 | ||
| * fix: run current File not respecting `preview mode` option. by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1805 | ||
| * fix: memory leak when toggling search panel by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1808 | ||
| * fix: prevent mixed content in SFTP/FTP cached files by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1815 | ||
| * Fix: Remove trimming of matched content in Executor.js by @dikidjatar in https://github.com/Acode-Foundation/Acode/pull/1798 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog contains several entries that don't follow the conventional commit format (type(scope): message). This makes the changelog less consistent and harder to parse automatically. Please consider rephrasing them to improve consistency.
For example:
- Line 26:
Added testscould betest: add initial test suiteor something more descriptive. - Line 27:
CustomTabs web api for pluginscould befeat: add CustomTabs web API for plugins. - Line 30:
Refactor quicktools settingscould berefactor: refactor quicktools settings. - Line 47:
Fix:should be lowercasefix:.
Greptile OverviewGreptile SummaryVersion bump from v1.11.7 to v1.11.8, including a temporary workaround that disables virtual scrolling in the FileTree component.
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CL as CHANGELOG.md
participant PJ as package.json
participant CX as config.xml
participant FT as fileTree/index.js
participant Build as Build System
Dev->>CL: Add v1.11.8 release notes
Note over CL: Document 30 features, 17 fixes,<br/>CI updates, and translations
Dev->>PJ: Update version to 1.11.8
Note over PJ: Increment version field
Dev->>CX: Update version to 1.11.8 (967)
Note over CX: Increment both version<br/>and versionCode
Dev->>FT: Disable virtual scrolling
Note over FT: Set VIRTUALIZATION_THRESHOLD<br/>to Infinity (temporary fix)
Dev->>Build: Trigger release build
Build-->>Dev: Build v1.11.8 (967)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| import tag from "html-tag-js"; | ||
| import helpers from "utils/helpers"; | ||
| import Path from "utils/Path"; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/fileTree/index.js
Line: 7:7
Comment:
Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.
How can I resolve this? If you propose a fix, please make it concise.
No description provided.