Skip to content

Conversation

@bajrangCoder
Copy link
Member

No description provided.

@github-actions github-actions bot added the docs label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily serves as a version bump to v1.11.8, incorporating a substantial collection of new features, bug fixes, and infrastructure improvements. It reflects a period of active development, enhancing user experience, developer tooling, and application stability across various modules without introducing breaking changes that would require a major version increment.

Highlights

  • Version Bump: The project version has been updated to v1.11.8, with the android-versionCode incremented to 967. This release consolidates a significant amount of development work.
  • Extensive New Features: This release introduces a wide array of new functionalities, including an Acode CLI, a FileTree component with virtual scrolling (though virtualization is temporarily disabled in this PR), a welcome tab for first-time users, enhanced terminal features (visibility toggle, smart path shortening, 'Open in Terminal' option), improved DevContainer and Docker support, Eruda devtools for debugging, and new plugin capabilities like a documents viewer.
  • Critical Bug Fixes: Numerous bugs have been addressed, such as timezone issues, sanitization of plugin readmes, various terminal and sidebar glitches, improvements to backup and restore processes, resolution of memory leaks, and prevention of mixed content in SFTP/FTP cached files.
  • CI/CD and Dependency Updates: Significant updates have been made to CI workflows, including the addition of F-droid builds in nightly releases and enhancements to release notes generation. Several dependencies have also been bumped to newer versions.
  • Internationalization Improvements: A large number of translation files have been updated or added, expanding language support for the application.
  • FileTree Virtualization Adjustment: The VIRTUALIZATION_THRESHOLD for the FileTree component has been temporarily set to Number.POSITIVE_INFINITY to address ongoing scrolling issues, effectively disabling virtualization for now.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version to v1.11.8. The changes include updating the version in configuration files, adding a comprehensive changelog, and a temporary fix to disable virtualization in the file tree component. My review focuses on improving the consistency of the changelog and highlighting the performance implications of disabling virtualization, with a recommendation to track this as technical debt.

import Path from "utils/Path";

const VIRTUALIZATION_THRESHOLD = 100;
const VIRTUALIZATION_THRESHOLD = Number.POSITIVE_INFINITY; // FIX: temporary due to some scrolling issues in VirtualList
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling virtualization by setting VIRTUALIZATION_THRESHOLD to Infinity can lead to significant performance degradation when rendering directories with a large number of files. While the comment indicates this is a temporary fix for scrolling issues, it's a critical performance feature being disabled.

It's strongly recommended to create a technical debt ticket to track this issue and ensure that the underlying scrolling problem in VirtualList is addressed and virtualization is re-enabled. Leaving this as-is could negatively impact user experience for those with large projects.

Comment on lines +26 to +47
* Added tests by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1813
* CustomTabs web api for plugins by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1785
* Implement plugin loading callbacks and tracking for installed plugins by @7HR4IZ3 in https://github.com/Acode-Foundation/Acode/pull/1558
* Added Documents viewer plugin id to load pdf/excel/csv etc. files by @hackesofice in https://github.com/Acode-Foundation/Acode/pull/1833
* Refactor quicktools settings by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1761

### Fixes
* fix: use correct timezone by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1716
* fix: sanitize plugin readme before rendering by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1731
* fix: make rm wrapper silent by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1727
* fix: remove duplicate rm command by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1732
* fix: sidebar app icon size and scrolling by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1733
* fix: terminal bug by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1741
* fix: sidebar apps active and removal things with fallback by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1749
* fix: improve the backup and restore by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1744
* fix: console by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1763
* fix(terminal): cleanup broken tabs and show alerts on terminal errors by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1780
* fix(plugin): sanitize markdown and prevent horizontal overflow by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1782
* fix: run current File not respecting `preview mode` option. by @UnschooledGamer in https://github.com/Acode-Foundation/Acode/pull/1805
* fix: memory leak when toggling search panel by @RohitKushvaha01 in https://github.com/Acode-Foundation/Acode/pull/1808
* fix: prevent mixed content in SFTP/FTP cached files by @bajrangCoder in https://github.com/Acode-Foundation/Acode/pull/1815
* Fix: Remove trimming of matched content in Executor.js by @dikidjatar in https://github.com/Acode-Foundation/Acode/pull/1798
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog contains several entries that don't follow the conventional commit format (type(scope): message). This makes the changelog less consistent and harder to parse automatically. Please consider rephrasing them to improve consistency.

For example:

  • Line 26: Added tests could be test: add initial test suite or something more descriptive.
  • Line 27: CustomTabs web api for plugins could be feat: add CustomTabs web API for plugins.
  • Line 30: Refactor quicktools settings could be refactor: refactor quicktools settings.
  • Line 47: Fix: should be lowercase fix:.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

Version bump from v1.11.7 to v1.11.8, including a temporary workaround that disables virtual scrolling in the FileTree component.

  • Version updated consistently across package.json, config.xml (including versionCode 966→967), and changelog
  • Comprehensive changelog documents 30+ features, 17 fixes, CI improvements, and translation updates
  • Virtual scrolling temporarily disabled in FileTree component by setting VIRTUALIZATION_THRESHOLD to Infinity—this is a workaround for scrolling issues but removes performance optimization for large directories

Confidence Score: 4/5

  • Safe to merge with minor performance consideration
  • Version bump is correctly implemented across all files with comprehensive changelog. The fileTree change is a documented temporary workaround that trades performance optimization for stability. While not ideal long-term, it's an acceptable temporary fix that won't break functionality.
  • Monitor src/components/fileTree/index.js - the virtual scrolling workaround should be tracked and re-enabled once underlying issues are resolved

Important Files Changed

Filename Overview
src/components/fileTree/index.js Disabled virtual scrolling by setting threshold to Infinity as temporary workaround for scrolling issues

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CL as CHANGELOG.md
    participant PJ as package.json
    participant CX as config.xml
    participant FT as fileTree/index.js
    participant Build as Build System
    
    Dev->>CL: Add v1.11.8 release notes
    Note over CL: Document 30 features, 17 fixes,<br/>CI updates, and translations
    
    Dev->>PJ: Update version to 1.11.8
    Note over PJ: Increment version field
    
    Dev->>CX: Update version to 1.11.8 (967)
    Note over CX: Increment both version<br/>and versionCode
    
    Dev->>FT: Disable virtual scrolling
    Note over FT: Set VIRTUALIZATION_THRESHOLD<br/>to Infinity (temporary fix)
    
    Dev->>Build: Trigger release build
    Build-->>Dev: Build v1.11.8 (967)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

import tag from "html-tag-js";
import helpers from "utils/helpers";
import Path from "utils/Path";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/fileTree/index.js
Line: 7:7

Comment:
Virtual scrolling is now completely disabled. All folder contents will always be rendered at once, which could cause performance issues with large directories (the feature was designed to handle directories with >100 items efficiently). Track and resolve the underlying scrolling issues to re-enable this optimization.

How can I resolve this? If you propose a fix, please make it concise.

@bajrangCoder bajrangCoder merged commit e2acb9b into Acode-Foundation:main Jan 28, 2026
6 checks passed
@bajrangCoder bajrangCoder deleted the v1.11.8 branch January 28, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant