Fix bug w/ url_utils.filepath_from_url + rel paths with a single "/"#1862
Merged
meshula merged 2 commits intoAcademySoftwareFoundation:mainfrom Apr 1, 2025
Merged
Conversation
ssteinbach
force-pushed
the
relative_path_otioz
branch
from
75b8d5e to
98a532a
Compare
ssteinbach
added
the
Adapters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.61%
==========================================
Files 198 177 -21
Lines 22241 12809 -9432
Branches 4687 1191 -3496
==========================================
- Hits 18709 10853 -7856
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 129 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jminor
approved these changes
Mar 31, 2025
* Relative paths with one "/" and not two "/" were triggering a traceback - ie "./blah" but not "./blah/blah".
ssteinbach
force-pushed
the
relative_path_otioz
branch
from
98a532a to
8bd1e99
Compare
reinecke
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817