-
Notifications
You must be signed in to change notification settings - Fork 20
Add tests into ServiceSubscriptions resource. #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mkudlej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pytlint output:
tests/integration/test_integration_service_subscriptions.py:35:0: C0304: Final newline missing (missing-final-newline)
threescale_api/resources.py:294:0: W0613: Unused argument 'kwargs' (unused-argument)
|
`pipenv run python -m pytest tests/integration/test_integration_service_subscriptions.py |& tee x tests/integration/test_integration_service_subscriptions.py EEEEE [100%] ==================================== ERRORS ==================================== account_params = {'org_name': 'test-LkYi_Vj3i50', 'username': 'test-LkYi_Vj3i50'}
tests/integration/conftest.py:127: threescale_api/resources.py:189: in create self = <threescale_api.client.ThreeScaleClient object at 0x7f2f9b9a0aa0>
E TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' threescale_api/client.py:138: TypeError account_params = {'org_name': 'test-LkYi_Vj3i50', 'username': 'test-LkYi_Vj3i50'}
tests/integration/conftest.py:127: threescale_api/resources.py:189: in create self = <threescale_api.client.ThreeScaleClient object at 0x7f2f9b9a0aa0>
E TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' threescale_api/client.py:138: TypeError account_params = {'org_name': 'test-LkYi_Vj3i50', 'username': 'test-LkYi_Vj3i50'}
tests/integration/conftest.py:127: threescale_api/resources.py:189: in create self = <threescale_api.client.ThreeScaleClient object at 0x7f2f9b9a0aa0>
E TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' threescale_api/client.py:138: TypeError account_params = {'org_name': 'test-LkYi_Vj3i50', 'username': 'test-LkYi_Vj3i50'}
tests/integration/conftest.py:127: threescale_api/resources.py:189: in create self = <threescale_api.client.ThreeScaleClient object at 0x7f2f9b9a0aa0>
E TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' threescale_api/client.py:138: TypeError account_params = {'org_name': 'test-LkYi_Vj3i50', 'username': 'test-LkYi_Vj3i50'}
tests/integration/conftest.py:127: threescale_api/resources.py:189: in create self = <threescale_api.client.ThreeScaleClient object at 0x7f2f9b9a0aa0>
E TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' threescale_api/client.py:138: TypeError |
| asserts.assert_resource(service_subscription) | ||
| asserts.assert_resource(account) | ||
| asserts.assert_resource(service_plan) | ||
| resource = account.service_subscriptions.approve(service_subscription.entity_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to simplified this line.
Add test for approve and change Service Subscription.