Add test for X served by response header #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkudlej
requested changes
Feb 15, 2025
Collaborator
mkudlej
left a comment
mkudlej
left a comment
There was a problem hiding this comment.
Please split this PR to 2 PRs: First will contain changes for service subscription, the second one only for response headers.
tests/test_response_headers.py
Outdated
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def cl(): |
Collaborator
There was a problem hiding this comment.
There is a fixture already in conftest, see
Collaborator
There was a problem hiding this comment.
Also please squash all commits in one PR into one. In this case there is no need to have more than one commit in one PR.
Get admin/api/accounts/find Get admin/api/accounts/plan
…Service Subscription
Add test for testing response headers Add test for response headers Adding test for response headers Add test for response headers, modify ServiceSubscription unit test Adding test for response headers Resolve conflicts of lint in PR
…on into x-served-by
mkudlej
requested changes
Feb 19, 2025
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in order to add test for response header X-Served-By