Fix ExpressionHelper.TryConvertTypes to generate correct Convert in case left or right is null#954
Merged
Fix ExpressionHelper.TryConvertTypes to generate correct Convert in case left or right is null#954
Conversation
…ase left or right is null
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves null handling in type conversion when comparing objects with non-object types in dynamic LINQ queries, particularly for JSON parsing scenarios. The changes ensure that null object values are properly converted to default values instead of causing runtime exceptions.
- Enhanced
TryConvertTypesto use conditional expressions that check for null before conversion - Updated
GenerateDefaultExpressionfor NET35 to properly handle value types and reference types - Refactored test variable names and data structures for improved clarity
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs | Added null-safe conversion logic with conditional expressions and improved NET35 default value generation |
| src/System.Linq.Dynamic.Core/Parser/IExpressionHelper.cs | Removed unnecessary public modifier from interface method |
| src/System.Linq.Dynamic.Core.NewtonsoftJson/NewtonsoftJsonExtensions.cs | Refactored to use collection expression and extracted func result to local variable |
| test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs | Renamed test variables for clarity and changed List to array |
| test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs | Added test for non-existing member comparisons with new imports |
| test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs | Added test for non-existing member comparisons and commented-out test for optional properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs
Outdated
Show resolved
Hide resolved
…sonTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs
Show resolved
Hide resolved
This was referenced Nov 10, 2025
This was referenced Nov 17, 2025
This was referenced Dec 15, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…