make fragments' Test.fromData be generated by relay compiler#635
Open
tsnobip wants to merge 1 commit into
Open
make fragments' Test.fromData be generated by relay compiler#635tsnobip wants to merge 1 commit into
Test.fromData be generated by relay compiler#635tsnobip wants to merge 1 commit into
Conversation
this allows to not export the `Fragment` from a relay component to keep fast refresh this implementation also makes it typesafe
tsnobip
force-pushed
the
generate-test-module-from-relay-compiler
branch
from
7915896 to
8014ef2
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to not export the
Fragmentfrom a relay component to keep fast refresh.This implementation also makes it typesafe.
to be used with zth/relay#39