Skip to content

Proper address checking for all CryptoNote currencies #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fancoder wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proper address checking for all CryptoNote currencies #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c1192
Proper address checking for all CryptoNote currencies
fancoder Jul 3, 2014
5f50ff2
Miner address validation based on pool address
fancoder Jul 3, 2014
7b46a02
Fix error with calling cnUtil.address_decode()
fancoder Jul 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ var shareTrustMinFloat = shareTrustEnabled ? config.poolServer.shareTrust.min /

var banningEnabled = config.poolServer.banning && config.poolServer.banning.enabled;

var addressBase58Prefix = cnUtil.address_decode(new Buffer(config.poolServer.poolAddress));


setInterval(function(){
var now = Date.now() / 1000 | 0;
Expand Down Expand Up @@ -440,7 +442,7 @@ function handleMinerMethod(method, params, ip, portData, sendReply, pushMessage)
sendReply('missing login');
return;
}
if (!utils.isValidAddress(params.login, config.poolServer.poolAddress[0])){
if (addressBase58Prefix !== cnUtil.address_decode(new Buffer(params.login))) {
sendReply('invalid address used for login');
return;
}
Expand Down
14 changes: 0 additions & 14 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,3 @@ exports.ringBuffer = function(maxSize){
exports.varIntEncode = function(n){

};

exports.isValidAddress = function(addr, prefix){

if (addr.length !== 95) return false;
if (addr[0] !== prefix) return false;
try{
var decoded = cnUtil.address_decode(new Buffer(addr));
return decoded.length > 0;
}
catch(e){
return false;
}

};