chore: world_heritage-split-command-refactor#386
Merged
zigzagdev merged 1 commit intochore/integrate-image_url-into-image-tablefrom Mar 28, 2026
Conversation
13 tasks
There was a problem hiding this comment.
Pull request overview
This PR refactors the World Heritage JSON split/import preparation to remove redundant image URL fields from world_heritage_sites and to improve criteria parsing/cleanup while preparing image rows for de-duplication.
Changes:
- Stop writing
image_url/primary_image_urlinto normalized site rows and stop mergingimage_urlfrom incoming rows. - Adjust image row generation logic in the split output (intended: support de-dup via hashing).
- Refactor criteria extraction to fix a variable naming bug and centralize deduplication.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
zigzagdev
merged commit 22f12dc
into
chore/integrate-image_url-into-image-table
29 checks passed
zigzagdev
deleted the
chore/delete-command-writing-image_url-into-heritage-command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
image_urlandprimary_image_urlwrites fromnormalizeSiteRowImportReadyimage_urlwrite frommergeSiteRowPreferExistingurl_hash(sha256) to image rows for de-dup upsertextractCriteriaList($s → $stringText)Why
image_url/primary_image_urlon the main table is redundant withworld_heritage_site_images.Persisting images only in the images table makes the data source of truth clear and avoids inconsistency.