feat(goto): goto definition prefers builtin This() #2582
Merged
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotcarmen
changed the title
dotcarmen
force-pushed
the
dotcarmen/goto-this
branch
from
f36c6e5 to
2f295e5
Compare
Contributor
|
im not sure i like this happening for all structs, i have a local change that is similar but instead stores the |
dotcarmen
force-pushed
the
dotcarmen/goto-this
branch
from
2f295e5 to
b5b5705
Compare
dotcarmen
commented
Jan 23, 2026
Comment on lines
+358
to
+359
| \\const <decl>S</decl> = struct { | ||
| \\ const <def>Self</def> = @This(); |
Contributor
Author
There was a problem hiding this comment.
@xdBronch see here - note that the declaration is still const S, but the definition is const Self. I'm still open to making the definition const S, but curious to know if this is suitable
(also just realized my PR description isn't the most precise about this, fixing now...)
Techatrix
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1596
consider goto on
Iofromstd.Io. goto definition currently goes to the beginning of the file, but it's typically more helpful to go toIoin its internal declarationconst Io = @This().contrary to the issue description, this PR also goes-to such definitions for non-file container definitions. Note that goto-declaration still goes to the outer declaration, while goto-definition now goes to the
@This()declaration if it exists.