Rename the DimensionNames type to DimensionNamesLike.#3800
Merged
d-v-b merged 1 commit intozarr-developers:mainfrom Mar 20, 2026
Merged
Rename the DimensionNames type to DimensionNamesLike.#3800d-v-b merged 1 commit intozarr-developers:mainfrom
DimensionNames type to DimensionNamesLike.#3800d-v-b merged 1 commit intozarr-developers:mainfrom
Conversation
The reason for this change is the fact that the `DimensionNames` type is does not model the actual type of the `dimension_names` attribute on the Array V3 Metadata class, but rather a wider input type that is ultimately narrowed to that actual type. For this reason, it should use the same `XLike` name convention as the other wide input types that get narrowed to a more restricted type.
maxrjones
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this change is the fact that the
DimensionNamestype is does not model theactual type of the
dimension_namesattribute on the Array V3 Metadata class, but rather awider input type that is ultimately narrowed to that actual type. For this reason, it should
use the same
XLikename convention as the other wide input types that get narrowed to a morerestricted type.