Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #3676 and #3677
This PR demos a Zarr array class that supports lazy indexing. When you index this array, the result is something with the same type. This is a stark contrast to the behavior of
zarr.Array, which returns a completely different thing (a numpy array) when you index it. This implementation is heavily inspired by tensorstore.here's a self-contained demo:
The Zarr array defined here should be thought of as a variably-sized view of another array.
Making this work requires adding attributes to the array that track the domain of the array's indices. These lazy arrays have an explicit origin in indexing space, and that origin can be negative. This means negative indexing does not wrap around! That's possibly the biggest semantic change here.
I'm still working on this, so I'm opening it as a draft for visibility. Lots of things might change, so expect an update or a new comment down the road that gives an overview once the design has cooled down.