Maintenance: Improve rspec handling

.rubocop_todo.yml

@@ -27,9 +27,3 @@ RSpec/DescribeMethod:
 
 RSpec/ContextWording:
   Enabled: false
-
-RSpec/BeforeAfterAll:
-  Enabled: false
-
-RSpec/LeakyLocalVariable:
-  Enabled: false

spec/zammad_api/client_spec.rb

@@ -2,11 +2,11 @@
 require 'logger'
 
 describe ZammadAPI::Client do
-  before(:all) do
+  before(:all) do # rubocop:disable RSpec/BeforeAfterAll
     WebMock.enable!
   end
 
-  after(:all) do
+  after(:all) do # rubocop:disable RSpec/BeforeAfterAll
     WebMock.disable!
   end
 

spec/zammad_api/resources/group_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'group object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  name = "some_group#{Helper.random}"
-  group = nil
+  let(:name) { "some_group#{Helper.random}" }
+  let(:group) { nil }
 
   it 'new with invalid attributes' do
     group_invalid = client.group.new

spec/zammad_api/resources/organization_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'organization object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  name = "some_organization#{Helper.random}"
-  organization = nil
+  let(:name) { "some_organization#{Helper.random}" }
+  let(:organization) { nil }
 
   it 'new with invalid attributes' do
     organization_invalid = client.organization.new

spec/zammad_api/resources/ticket_priority_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'ticket priority object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  name = "some_ticket_priority#{Helper.random}"
-  ticket_priority = nil
+  let(:name) { "some_ticket_priority#{Helper.random}" }
+  let(:ticket_priority) { nil }
 
   it 'new with invalid attributes' do
     ticket_priority_invalid = client.ticket_priority.new

spec/zammad_api/resources/ticket_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'ticket object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  title = "some ticket title ##{Helper.random}"
-  ticket = nil
+  let(:title) { "some ticket title ##{Helper.random}" }
+  let(:ticket) { nil }
 
   it 'new with invalid attributes' do
     ticket_invalid = client.ticket.new

spec/zammad_api/resources/ticket_state_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'ticket state object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  name = "some_ticket_state#{Helper.random}"
-  ticket_state = nil
+  let(:name) { "some_ticket_state#{Helper.random}" }
+  let(:ticket_state) { nil }
 
   it 'new with invalid attributes' do
     ticket_state_invalid = client.ticket_state.new

spec/zammad_api/resources/user_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe ZammadAPI, 'user object basics' do
-  client = Helper.client
+  let(:client) { Helper.client }
 
-  random = Helper.random
-  firstname = "firstname#{random}"
-  lastname = "lastname#{random}"
-  email = "some_user#{random}@example.com"
-  user = nil
+  let(:firstname) { "firstname#{Helper.random}" }
+  let(:lastname) { "lastname#{Helper.random}" }
+  let(:email) { "some_user#{Helper.random}@example.com" }
+  let(:user) { nil }
 
   it 'new with invalid attributes' do
     user_invalid = client.user.new
@@ -61,7 +60,7 @@
     expect(user.created_by).to eq('admin@example.com')
     expect(user.updated_by).to eq('admin@example.com')
 
-    user.firstname = "firstname#{random}-2"
+    user.firstname = "firstname#{Helper.random}-2"
     user.roles = ['Agent']
     user.note = 'some note'
 

spec/zammad_api/transport_spec.rb

@@ -2,11 +2,11 @@
 require 'logger'
 
 describe ZammadAPI::Transport do
-  before(:all) do
+  before(:all) do # rubocop:disable RSpec/BeforeAfterAll
     WebMock.enable!
   end
 
-  after(:all) do
+  after(:all) do # rubocop:disable RSpec/BeforeAfterAll
     WebMock.disable!
   end
 

spec/zammad_api_spec.rb

@@ -6,8 +6,10 @@
   end
 
   context 'failing authentication' do
+    # TODO: this will be executed at test parsing time, not execution time. Consider improving this.
     Helper.auto_wizard
-    client = Helper.client(user: 'not_existing', password: 'not_existing')
+
+    let(:client) { Helper.client(user: 'not_existing', password: 'not_existing') }
 
     it 'user' do
       expect { client.user.find(1) }.to raise_error(RuntimeError)