autoscaler: ensure HPA min replicas is not below Stack replicas#441
Open
AlexanderYastrebov wants to merge 1 commit intozalando-incubator:masterfrom
Open
Conversation
Users may scale stack manually via `kubectl scale stack` which updates Stack `spec.replicas` but it would not work when HPA is present and has lower minReplicas value. This change ensures that Stack's HPA min replicas is not below Stack `spec.replicas` (if present). Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| // clientsetscheme "k8s.io/client-go/kubernetes/scheme" | ||
| // aggregatorclientsetscheme "k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/scheme" | ||
| // ) | ||
| // import ( |
Contributor
Author
There was a problem hiding this comment.
This change is due to go1.19 formatting changes
Member
|
👍 |
demonCoder95
added
bug
Member
|
@AlexanderYastrebov do you think it's better to handle this here, or should we handle this in the admission-controller? 🤔 I re-opened the PR because the PR seems to provide a useful patch 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users may scale stack manually via
kubectl scale stackwhich updates Stackspec.replicasbut it would not work when HPA is present and has lower minReplicas value.This change ensures that Stack's HPA min replicas is not below Stack
spec.replicas(if present).Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de