iOS: Allow WiFi-only setups when WDA is reachable #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WiFi mode, idevice_id may return no devices even though WebDriverAgent is running and reachable. This change falls back to checking WDA readiness when no USB devices are detected, preventing the CLI from exiting early in WiFi-only configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using AutoGLM on iOS over WiFi, WebDriverAgent (WDA) can be reachable (for example, with --wda-url http://{device-ip}:8100) while idevice_id -ln returns no devices.
The CLI currently treats this as a hard failure and exits during the system requirements check.
What changed
Why
This prevents false negatives for WiFi-only configurations and aligns the preflight checks with the actual runtime dependency (WDA accessibility).
Testing