fix: correct numeric string coercion with leading zeros#535
Draft
ljluestc wants to merge 1 commit intoyuin:masterfrom
Draft
fix: correct numeric string coercion with leading zeros#535ljluestc wants to merge 1 commit intoyuin:masterfrom
ljluestc wants to merge 1 commit intoyuin:masterfrom
Conversation
Use decimal-first parsing for numeric string coercion to avoid unintended octal interpretation for values like "00011", while preserving hex support (for example "0x7d6"). Add regression coverage for issue yuin#478 in both DoString-focused tests and glua issue script tests. Fixes yuin#478 Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #478
L.DoStringreturns an incorrect result for string-to-number coercion in arithmetic expressions.Repro script:
Expected:
12Actual:
10This is inconsistent with Lua 5.1 arithmetic coercion expectations for numeric strings.
What changed and how does it work?
This PR updates numeric coercion during arithmetic evaluation for string operands:
0x7d6._glua-tests/issues.lua.Why this approach?
Check List
Tests
go test -run 'TestDoStringNumericString(Coercion|HexCoercion)$' -count=1go test -run TestGlua -count=1a = "00001" + "00011"->12Documentation
Release note
Fix incorrect string numeric coercion in arithmetic so expressions like
"00001" + "00011"evaluate correctly.