Skip to content

Fix folder source path regression with createIntermediateGroups (#1603)#1605

Merged
yonaskolb merged 1 commit intomasterfrom
yonaskolb/fix-1603
Mar 10, 2026
Merged

Fix folder source path regression with createIntermediateGroups (#1603)#1605
yonaskolb merged 1 commit intomasterfrom
yonaskolb/fix-1603

Conversation

@yonaskolb
Copy link
Owner

Summary

  • Fixes type: folder source generates incorrect PBXFileReference path in 2.45.0 #1603 where type: folder sources generated a PBXFileReference with only the leaf directory name instead of the full relative path when createIntermediateGroups was enabled
  • PR Various synced folder enhancements #1596 added makePathRelative to the createIntermediateGroups code path for synced folders, but it inadvertently also ran for regular .folder sources which use sourceTree: .sourceRoot and need the full path preserved
  • Skips makePathRelative for .folder type sources; .syncedFolder and other types are unaffected

Test plan

  • Added test case "generates folder references with createIntermediateGroups"
  • Existing folder reference test still passes
  • Full test suite passes (74 tests, 0 failures)

🤖 Generated with Claude Code

…diateGroups

Skip makePathRelative for folder-type sources since they use sourceTree
.sourceRoot and need the full project-relative path preserved. The call
was inadvertently added for all source types in #1596 but only synced
folders (.syncedFolder) need it.

Fixes #1603
@yonaskolb yonaskolb merged commit 8cfdf30 into master Mar 10, 2026
6 checks passed
@yonaskolb yonaskolb deleted the yonaskolb/fix-1603 branch March 10, 2026 13:44
@Lutzifer
Copy link
Contributor

thx for the fix, it came faster than I could create an issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

type: folder source generates incorrect PBXFileReference path in 2.45.0

2 participants