Fix folder source path regression with createIntermediateGroups (#1603)#1605
Merged
Fix folder source path regression with createIntermediateGroups (#1603)#1605
Conversation
Contributor
|
thx for the fix, it came faster than I could create an issue for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type: foldersources generated a PBXFileReference with only the leaf directory name instead of the full relative path whencreateIntermediateGroupswas enabledmakePathRelativeto thecreateIntermediateGroupscode path for synced folders, but it inadvertently also ran for regular.foldersources which usesourceTree: .sourceRootand need the full path preservedmakePathRelativefor.foldertype sources;.syncedFolderand other types are unaffectedTest plan
🤖 Generated with Claude Code