Skip to content

adding support for adding files that are not associated with a target#1268

Open
skofgar wants to merge 5 commits into
yonaskolb:masterfrom
skofgar:feature/project-files
Open

adding support for adding files that are not associated with a target#1268
skofgar wants to merge 5 commits into
yonaskolb:masterfrom
skofgar:feature/project-files

Conversation

@skofgar

@skofgar skofgar commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

For some projects it might be helpful to add files to a project that don't belong to a specific target.

For example, README.md files or the project.yml.

files:
  - path: README.md
  - path: project.yml
  - path: Resources/Config
    name: Config
    includes:
      - "*.json"

Known Issues

  • Currently I just use TargetSources to achieve this capability. If the general direction of this PR is acceptable, then I would - in a separate PR - rename TargetSources to SourcesReference (or something similar)

@skofgar skofgar changed the title adding support for adding files that don't belong to a target adding support for adding files that are not associated with a target Sep 29, 2022
@skofgar

skofgar commented Oct 7, 2022

Copy link
Copy Markdown
Contributor Author

Hi @yonaskolb may I request a review for this PR?

@yonaskolb

Copy link
Copy Markdown
Owner

Interestingly this is what fileGroups is for. The name doesn't suggest it can be used for single files though. Are the options exposed by TargetSource required for your use case? If not, perhaps we just deprecate and rename fileGroups to files, while still supporting fileGroups for backwards compatibility.

@skofgar

skofgar commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Oh really 🤦‍♂️, sorry I didn’t realize it.

I do have a use case where the include filter options would be really helpful.

I’ll look into fileGroups more and update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants