-
-
Notifications
You must be signed in to change notification settings - Fork 4
Support SelectQuery #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DAGpro
commented
Nov 22, 2025
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=============================================
+ Coverage 80.76% 97.66% +16.89%
+ Complexity 116 102 -14
=============================================
Files 23 24 +1
Lines 312 300 -12
=============================================
+ Hits 252 293 +41
+ Misses 60 7 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@samdark ? |
|
Looks alright. Please add a line for CHANGELOG. |
roxblnfk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look OK
Need to add a few tests with SelectQuery to cover it
|
Looks like FilterHandlerInterface was removed. |
|
Is it necessary to write to the changelog? The package is not released. |
|
Adding a changelog is not required for unreleased packages. |