Skip to content

Conversation

@DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Nov 22, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (087e695) to head (327dd16).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #44       +/-   ##
=============================================
+ Coverage     80.76%   97.66%   +16.89%     
+ Complexity      116      102       -14     
=============================================
  Files            23       24        +1     
  Lines           312      300       -12     
=============================================
+ Hits            252      293       +41     
+ Misses           60        7       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DAGpro
Copy link
Contributor Author

DAGpro commented Nov 30, 2025

@samdark ?

@samdark
Copy link
Member

samdark commented Dec 2, 2025

Looks alright. Please add a line for CHANGELOG.

@samdark samdark requested a review from roxblnfk December 2, 2025 07:33
Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK
Need to add a few tests with SelectQuery to cover it

@roxblnfk
Copy link
Member

roxblnfk commented Dec 19, 2025

Looks like FilterHandlerInterface was removed.
Need to stop using dev-master for the yii/data package

@DAGpro
Copy link
Contributor Author

DAGpro commented Dec 19, 2025

Is it necessary to write to the changelog? The package is not released.

@rustamwin
Copy link
Member

Adding a changelog is not required for unreleased packages.

@samdark samdark merged commit f117ea4 into yiisoft:master Dec 20, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants