Add tests to kill escaped mutants (#529) by dbuhonov · Pull Request #545 · yiisoft/active-record

dbuhonov · 2026-03-13T09:05:18Z

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Fixed issues	part of #529

codecov · 2026-03-13T09:07:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (e686a15) to head (dc1ccc0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##              master     #545      +/-   ##
=============================================
- Coverage     100.00%   99.93%   -0.07%     
  Complexity       655      655              
=============================================
  Files             43       43              
  Lines           1629     1605      -24     
=============================================
- Hits            1629     1604      -25     
- Misses             0        1       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…e components

…itoryTraitTest`

… in EventsTraitTest.

…multiple test files.

…tomization

…nd `RelationPopulator`

…andlers

…ON handling

…ry` visibility

… behavior in RelationPopulator

…opulator` tests

…HERE clause

…ions.

…nt tests

…igurations

…ation testing.

Copilot

Pull request overview

This PR aims to increase mutation testing score (Issue #529) by adding/adjusting unit tests around ActiveRecord/ActiveQuery edge-cases (relations population/reset, upsert behavior, event dispatching, array access, etc.) and updating Infection configuration.

Changes:

Added new tests covering previously untested branches/edge-cases in ActiveRecord, ActiveQuery, EventsTrait, Arrayable/ArrayAccess traits, RepositoryTrait, and MagicActiveRecord behavior.
Introduced additional test stubs to exercise deep via() relations, event-enabled models, and ArrayAccess edge-cases involving name collisions between properties and relations.
Updated infection.json.dist to ignore several specific mutators/locations.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Stubs/MagicActiveRecord/CategoryWithNameRelationArrayAccess.php	New stub to test ArrayAccess behavior when a relation name collides with a column/property name.
tests/Stubs/ActiveRecord/OrderItemWithDeepViaProfile.php	New stub to test deep `via()` chains and relation population behavior.
tests/Stubs/ActiveRecord/CustomerEventsModel.php	New stub enabling EventsTrait on a Customer derivative for event dispatch tests.
tests/Stubs/ActiveRecord/OrderItemWithConstructor.php	Doc comment fix to match the class name.
tests/RepositoryTraitTest.php	Adds coverage for `find()` behavior when condition is null (params should be ignored).
tests/MagicActiveRecordTest.php	Adds coverage for new-record save paths and property capability checks.
tests/EventsTraitTest.php	Adds coverage for delete prevention and “after” event dispatching + handler behavior.
tests/Driver/Pgsql/ActiveQueryTest.php	Adds PG-specific assertions for `ModelRelationFilter` condition types (array/json/scalar).
tests/ArrayableTraitTest.php	Adds coverage for `extraFields()` behavior when relations are populated.
tests/ArrayAccessTraitTest.php	Expands coverage for ArrayAccess edge-cases (property vs relation, magic properties, dependent-relation reset).
tests/ActiveRecordTest.php	Adds multiple tests for relation reset, populateProperties behavior, cloning semantics, linking/unlinking edge-cases, counters, overrides, and upsert defaults.
tests/ActiveQueryTest.php	Adds broad coverage around helper internals, joinWith parsing/behavior, relation population, via behavior, cloning, and filter application.
infection.json.dist	Adds multiple mutator ignore rules / regex-based ignores.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/ActiveRecordTest.php

dbuhonov · 2026-03-19T12:22:01Z

infection.json.dist

+        "ConcatOperandRemoval": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Trait\\MagicRelationsTrait::relationQuery",
+                "Yiisoft\\ActiveRecord\\Trait\\MagicRelationsTrait::relationNames"
+            ]
+        },
+        "FalseValue": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Event\\Handler\\SetValueOnUpdate::beforeUpsert"
+            ]
+        },
+        "LogicalAnd": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Internal\\JoinsWithBuilder::joinWithRelations"
+            ]
+        },
+        "MatchArmRemoval": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Event\\Handler\\SetValueOnUpdate::beforeUpsert"
+            ]
+        },
+        "MethodCallRemoval": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Internal\\JoinsWithBuilder::build"
+            ]
+        },
+        "TrueValue": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\ActiveRecord::upsertInternal"
+            ],
+            "ignoreSourceCodeByRegex": [
+                "protected function upsertInternal\\(\\?array \\$insertProperties = null, array\\|bool \\$updateProperties = true\\): void"
+            ]
+        },
+        "UnwrapArrayValues": {
+            "ignore": [
+                "Yiisoft\\ActiveRecord\\Internal\\JoinsWithBuilder::build"
+            ]
+        }


These exclusions are for survivors that are not obvious from the test diff itself, so I moved them into infection.json.dist intentionally to make them explicit and visible rather than leaving them hidden in the report only.

…eryTest`.

…on and records

…lumn schema

…cordTest`.

…ActiveRecordTest`.

Copilot

Pull request overview

This PR adds/extends PHPUnit coverage across ActiveRecord, ActiveQuery, events, array access/arrayable behavior, and several internal helpers to improve mutation score (Issue #529) by exercising previously untested branches and edge-cases.

Changes:

Added many new tests around relation population/reset, upsert/link/unlink edge cases, event dispatching, and query/join/via behaviors.
Introduced multiple new test stub ActiveRecord/ActiveQuery classes to support targeted scenarios (deep via relations, composite PKs, overridden internals, etc.).
Updated Infection configuration with explicit mutator ignores for specific survivors.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Stubs/MagicActiveRecord/CategoryWithNameRelationArrayAccess.php	New stub for ArrayAccess + magic relation name collision scenarios.
tests/Stubs/ActiveRecord/OrderWithCustomerProfileViaCustomerRelation.php	New stub to exercise nested “via” relation dependency handling.
tests/Stubs/ActiveRecord/OrderItemWithDeepViaProfile.php	New stub to cover deep via chain relation population.
tests/Stubs/ActiveRecord/OrderItemWithConstructor.php	Docblock fix for stub class name.
tests/Stubs/ActiveRecord/EmployeeWithPrototypeDossierRelation.php	New stub for prototype-cloned relation target and stricter PK checks.
tests/Stubs/ActiveRecord/CustomerWithUpdateInternalOverride.php	New stub to test overridable `updateInternal()`.
tests/Stubs/ActiveRecord/CustomerWithRefreshInternalOverride.php	New stub to test overridable `refreshInternal()`.
tests/Stubs/ActiveRecord/CustomerWithOverriddenRelationQuery.php	New stub to test overridable relation query creation.
tests/Stubs/ActiveRecord/CustomerWithDeleteInternalOverride.php	New stub to test overridable `deleteInternal()`.
tests/Stubs/ActiveRecord/CustomerSetValueOnUpdateUpsert.php	New stub for `SetValueOnUpdate` behavior during upsert.
tests/Stubs/ActiveRecord/CustomerEventsModel.php	New stub enabling `EventsTrait` on `Customer`.
tests/Stubs/ActiveRecord/CompositePrimaryKeyDossier.php	New stub for composite PK relation/linking scenarios.
tests/Stubs/ActiveQuery/SingleModelArrayActiveQuery.php	New stub to ensure `one()` path doesn’t fall back to `all()`.
tests/Stubs/ActiveQuery/OverriddenPrimaryTableNameActiveQuery.php	New stub to cover overriding primary table resolution.
tests/Stubs/ActiveQuery/OverriddenCreateModelsActiveQuery.php	New stub to cover overriding model creation from rows.
tests/Stubs/ActiveQuery/MissingLinkValuesActiveQuery.php	New stub for missing link values during relation population.
tests/Stubs/ActiveQuery/CreateModelsExceptionOnEmptyRowsActiveQuery.php	New stub ensuring empty populate doesn’t call `createModels()`.
tests/Stubs/ActiveQuery/AlternativeActiveQuery.php	New stub for alternate ActiveQuery implementation.
tests/RepositoryTraitTest.php	Added coverage for `find()` behavior with null condition/params handling.
tests/MagicActiveRecordTest.php	Added tests for save/update behavior and property accessor edge-cases.
tests/EventsTraitTest.php	Expanded event dispatch/handler behavior coverage (after-events, soft delete, defaults, etc.).
tests/Driver/Pgsql/ActiveQueryTest.php	Added PG-specific assertions for `ModelRelationFilter` conditions.
tests/ArrayableTraitTest.php	Added `extraFields()` coverage.
tests/ArrayAccessTraitTest.php	Expanded ArrayAccess tests for properties vs relations and magic properties.
tests/ActiveRecordTest.php	Added extensive relation reset/dependency, PK error message, upsert/link/unlink/counters, override hooks tests.
tests/ActiveQueryTest.php	Added extensive coverage for populate/dedup, joinWith validation, viaTable callable, relation population internals.
infection.json.dist	Added explicit mutator ignore configuration for remaining survivors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/ActiveRecordTest.php

tests/Stubs/ActiveRecord/CustomerWithRefreshInternalOverride.php

tests/Stubs/ActiveRecord/CustomerWithOverriddenRelationQuery.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

tests/Driver/Pgsql/ActiveQueryTest.php

tests/Stubs/ActiveRecord/CustomerWithDeleteInternalOverride.php

tests/Stubs/ActiveRecord/CustomerWithOverriddenRelationQuery.php

tests/Stubs/ActiveRecord/CustomerWithRefreshInternalOverride.php

tests/Stubs/ActiveRecord/CustomerWithUpdateInternalOverride.php

tests/Stubs/ActiveRecord/EmployeeWithPrototypeDossierRelation.php

…arity and coverage.

CHANGELOG.md

dbuhonov · 2026-03-24T07:32:36Z

Up review pls

Tigrov · 2026-03-26T05:58:45Z

tests/ActiveRecordTest.php

+
+        $dossier = clone $dossierPrototype;
+        $dossier->set('summary', 'Strict primary key validation');
+        if ($this->db()->getDriverName() !== 'sqlsrv') {


Why skip sqlsrv here?

Tigrov · 2026-03-26T06:05:46Z

tests/ActiveRecordTest.php

+
+        $this->assertSame(2, $dossier->get('department_id'));
+        $this->assertSame(2, $dossier->get('employee_id'));
+        $this->assertNotNull($dossier->get('id'));


Should it be equal to 100?

Tigrov · 2026-03-26T06:07:30Z

tests/ActiveRecordTest.php

+    public function testMarkPropertyChangedWithEmptyNameDoesNotModifyOldValues(): void
+    {
+        $customer = new Customer();
+        $customer->assignOldValues(['' => 'sentinel', 'name' => 'user1']);
+
+        $customer->markPropertyChanged('');
+
+        $this->assertSame(['' => 'sentinel', 'name' => 'user1'], $customer->oldValues());
+    }


Perhaps this is a bug and $customer->markPropertyChanged(''); should change it.

Tigrov · 2026-03-26T06:33:33Z

tests/ActiveRecordTest.php

+    public function testCreateRelationQueryCanBeOverridden(): void
+    {
+        $customer = new CustomerWithOverriddenRelationQuery();
+
+        $query = $customer->relationQuery('profile');
+
+        $this->assertNotSame(ActiveQuery::class, $query::class);
+    }
+
+    public function testCreateRelationQueryIsProtected(): void
+    {
+        $method = new ReflectionMethod(AbstractActiveRecord::class, 'createRelationQuery');
+
+        $this->assertTrue($method->isProtected());
+    }
+
+    public function testDeleteInternalCanBeOverridden(): void
+    {
+        $this->reloadFixtureAfterTest();
+
+        $customer = CustomerWithDeleteInternalOverride::query()->findByPk(1);
+
+        $this->assertSame(77, $customer->delete());
+        $this->assertNotNull(Customer::query()->findByPk(1));
+    }
+
+    public function testRefreshInternalCanBeOverridden(): void
+    {
+        $customer = CustomerWithRefreshInternalOverride::query()->findByPk(1);
+
+        $this->assertTrue($customer->refresh());
+        $this->assertSame('refreshed-via-override', $customer->getName());
+    }
+
+    public function testUpdateInternalCanBeOverridden(): void
+    {
+        $this->reloadFixtureAfterTest();
+
+        $customer = CustomerWithUpdateInternalOverride::query()->findByPk(1);
+
+        $customer->setName('should-not-hit-db');
+
+        $this->assertSame(91, $customer->update());
+        $this->assertSame('user1', Customer::query()->findByPk(1)->getName());
+    }


This is where the fundamentals of OOP (inheritance) are tested. This looks redundant, but if it is necessary, perhaps it would be better to create a separate class in which to define all methods which can be overridden.

Tigrov · 2026-03-26T06:41:38Z

tests/ArrayAccessTraitTest.php

+    public function testOffsetExistsDoesNotTreatPropertyAsRelation(): void
+    {
+        $model = new CustomerArrayAccessModel();
+        $model->name = 'test';
+
+        $this->assertTrue(isset($model['name']));
+        $this->assertFalse($model->isRelationPopulated('name'));
+    }


The test looks like testOffsetGetReturnsPropertyValue()

Suggested change

public function testOffsetExistsDoesNotTreatPropertyAsRelation(): void

{

$model = new CustomerArrayAccessModel();

$model->name = 'test';

$this->assertTrue(isset($model['name']));

$this->assertFalse($model->isRelationPopulated('name'));

}

Tigrov · 2026-03-26T07:59:51Z

tests/ActiveQueryTest.php

+        $this->assertSame('customer c!', $tableName);
+        $this->assertSame('customer c!', $alias);


Doesn't it looks like a bug?

Tigrov · 2026-03-26T08:00:19Z

tests/ActiveQueryTest.php

+        $this->assertSame($from, $tableName);
+        $this->assertSame($from, $alias);


Doesn't it look like a bug?

Tigrov · 2026-03-26T08:03:09Z

tests/ActiveQueryTest.php

+    {
+        $query = Customer::query();
+        $method = new ReflectionMethod(ActiveQuery::class, 'removeDuplicatedRows');
+        $method->setAccessible(true);


This is not required
https://www.php.net/manual/en/reflectionmethod.setaccessible.php

Note: As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default.

Suggested change

$method->setAccessible(true);

Tigrov · 2026-03-26T08:06:05Z

tests/ActiveQueryTest.php

+    public function testCreateModelsCanBeOverridden(): void
+    {
+        $query = new OverriddenCreateModelsActiveQuery(Customer::class);
+
+        $this->assertSame(
+            [['overridden' => true, 'rows' => [['id' => 1]]]],
+            $query->populate([['id' => 1]]),
+        );
+    }
+
+    public function testGetPrimaryTableNameCanBeOverridden(): void
+    {
+        $query = new OverriddenPrimaryTableNameActiveQuery(Customer::class);
+
+        $this->assertSame(['{{profile}}' => '{{profile}}'], $query->getTablesUsedInFrom());
+    }


This is where the fundamentals of OOP (inheritance) are tested. This looks redundant, but if it is necessary, perhaps it would be better to create a separate class in which to define all methods which can be overridden.

Tigrov · 2026-03-26T08:10:50Z

tests/ActiveQueryTest.php

+    public function testModelRelationFilterCompositeArrayModelsUseQualifiedColumnNames(): void
+    {
+        $query = Dossier::query()
+            ->from(['d' => 'dossier'])
+            ->join('INNER JOIN', 'employee e', '1=1')
+            ->link(['department_id' => 'department_id', 'employee_id' => 'employee_id']);
+
+        ModelRelationFilter::apply($query, [
+            ['department_id' => 2],
+        ]);
+
+        $where = $query->getWhere();
+
+        $this->assertInstanceOf(In::class, $where);
+        $this->assertSame(
+            [['d.department_id' => 2, 'd.employee_id' => null]],
+            array_values($where->values),
+        );
+    }


It looks like testModelRelationFilterCompositeKeysFillMissingValuesWithNull()

Fixed AbstractActiveRecord

27f1743

dbuhonov force-pushed the feature/529-mutant-part-1 branch from ec926d0 to 27f1743 Compare March 13, 2026 09:09

dbuhonov added 27 commits March 13, 2026 13:41

Fixed AbstractActiveRecord.php:454

aeecf63

Add test ensuring new records do not execute updates during save

ec920b3

Add test for resetting populated relation via property setter

f0eaf4b

Add test for handling models without a primary key

3b89f33

Add test for linking via relation with a new record

39ad6de

Add test for unlinking array-valued property with delete in ActiveRecord

5de7e0c

Add tests for intermediate relation population and reset conditions

4235f60

Add new test cases for ActiveQuery and EventsTrait functionality

91babdc

Add unit tests for edge cases and behavior refinements across multipl…

5d7bc96

…e components

Add tests for property handling in MagicActiveRecordTest and `Repos…

0154804

…itoryTraitTest`

Wrap event class instantiations in parentheses to enhance readability…

a2cca91

… in EventsTraitTest.

Refactor tests to improve consistency and simplify assertions across …

c4e2b9a

…multiple test files.

Add new tests for improving ActiveRecord and ActiveQuery behavior cus…

1d7e210

…tomization

Add comprehensive tests for ArArrayHelper, ModelRelationFilter, a…

9e400ec

…nd `RelationPopulator`

Add new test cases for ActiveQuery, ActiveRecord, traits, and event h…

5f106e9

…andlers

Fix spacing in JSON array assertion in ActiveRecordTest

0517a01

Fixes inconsistent formatting in ActiveRecordTest assertions for JS…

91c4b35

…ON handling

Fixes inconsistent formatting in ActiveRecordTest assertions for JS…

8daa965

…ON handling

Add tests for single model relation population and `createRelationQue…

0258502

…ry` visibility

Add tests for single model relation population and `createRelationQue…

8b0558c

…ry` visibility

Add test for table name and alias resolution with newline in alias

4abf941

Remove error handler for invoke calls and add test for missing bucket…

5cb4347

… behavior in RelationPopulator

Add CategoryWithNameRelationArrayAccess stub and enhance `RelationP…

af44084

…opulator` tests

Add OrderItemWithDeepViaProfile test stub and related test

58e9ed7

Add test to ensure joinWith via relation avoids duplicating child W…

db1387b

…HERE clause

Add test for RelationPopulator handling composite keys in arrays

3e4e335

Add test to verify joinWith avoids duplicating child where condit…

bc72ed6

…ions.

dbuhonov added 6 commits March 17, 2026 18:30

Update tests to handle database-specific constraints and refactor eve…

e2a77f1

…nt tests

Re-enable and update testPropertyAccess method in ActiveRecordTest

ab10e5a

Simplify infection.json.dist by removing mutator-specific ignore conf…

cee9d4a

…igurations

Adjust mutator configurations in infection.json.dist to improve mut…

a476f7d

…ation testing.

Add test for ModelRelationFilter handling array column conditions

1887462

Add tests for ModelRelationFilter with JSON and scalar column conditions

0e2ff77

samdark requested a review from Copilot March 18, 2026 20:38

Copilot AI reviewed Mar 18, 2026

View reviewed changes

dbuhonov added 6 commits March 19, 2026 15:55

Use ReflectionMethod without fully qualified namespace in `ActiveQu…

a110abf

…eryTest`.

Use ReflectionMethod without fully qualified namespace in `ActiveQu…

1899548

…eryTest`.

Add stub classes to test ActiveQuery and ActiveRecord behavior

8492865

Update ActiveRecordTest to improve assertions for relation populati…

b1ab39a

…on and records

Add test for ModelRelationFilter handling array column values with co…

c3a20fd

…lumn schema

Use ReflectionMethod without fully qualified namespace in `ActiveRe…

f0e4e68

…cordTest`.

dbuhonov marked this pull request as ready for review March 19, 2026 13:00

Add test to verify resetRelation updates relation dependencies in `…

a100844

…ActiveRecordTest`.

samdark requested a review from Copilot March 19, 2026 19:58

Copilot started reviewing on behalf of samdark March 19, 2026 19:58 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

tests/ActiveRecordTest.php Show resolved Hide resolved

tests/Stubs/ActiveRecord/CustomerWithRefreshInternalOverride.php Outdated Show resolved Hide resolved

tests/Stubs/ActiveRecord/CustomerWithOverriddenRelationQuery.php Outdated Show resolved Hide resolved

dbuhonov and others added 2 commits March 20, 2026 00:04

Update tests/Stubs/ActiveRecord/CustomerWithOverriddenRelationQuery.php

8fe24c9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/Stubs/ActiveRecord/CustomerWithRefreshInternalOverride.php

aaccff4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

samdark requested review from Tigrov and vjik March 19, 2026 20:08

Update CHANGELOG for Test yiisoft#529: Increase MSI to 100%

7804055

Tigrov reviewed Mar 21, 2026

View reviewed changes

Combine and revise array column tests in ModelRelationFilter for cl…

4dbfbf2

…arity and coverage.

vjik reviewed Mar 22, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG to reflect no changes in release 1.0.3

dc1ccc0

Tigrov reviewed Mar 26, 2026

View reviewed changes

		$this->assertSame('customer c!', $tableName);
		$this->assertSame('customer c!', $alias);

		$this->assertSame($from, $tableName);
		$this->assertSame($from, $alias);

Uh oh!

Conversation

dbuhonov commented Mar 13, 2026

Uh oh!

codecov bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbuhonov commented Mar 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tigrov Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tigrov Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tigrov Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 13, 2026 •

edited

Loading

Tigrov Mar 26, 2026 •

edited

Loading

Tigrov Mar 26, 2026 •

edited

Loading

Tigrov Mar 26, 2026 •

edited

Loading