Skip to content

Avoid unnecessary copying of request and response in proxy/redirect #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhirose merged 1 commit into from
Dec 17, 2025
Merged

Avoid unnecessary copying of request and response in proxy/redirect #2310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions httplib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6157,8 +6157,8 @@ inline bool redirect(T &cli, Request &req, Response &res,

auto ret = cli.send(new_req, new_res, error);
if (ret) {
req = new_req;
res = new_res;
req = std::move(new_req);
res = std::move(new_res);

if (res.location.empty()) { res.location = location; }
}
Expand Down Expand Up @@ -10554,7 +10554,7 @@ inline bool ClientImpl::handle_request(Stream &strm, Request &req,
auto req2 = req;
req2.path = "http://" + host_and_port_ + req.path;
ret = process_request(strm, req2, res, close_connection, error);
req = req2;
req = std::move(req2);
req.path = req_save.path;
} else {
ret = process_request(strm, req, res, close_connection, error);
Expand Down Expand Up @@ -10606,7 +10606,7 @@ inline bool ClientImpl::handle_request(Stream &strm, Request &req,
Response new_res;

ret = send(new_req, new_res, error);
if (ret) { res = new_res; }
if (ret) { res = std::move(new_res); }
}
}
}
Expand Down
Loading