Implement IntoIterator for IMap and IArray via their refs#68
Closed
kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
Closed
Implement IntoIterator for IMap and IArray via their refs#68kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
kirillsemyonkin wants to merge 1 commit intoyewstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a variant of implementing
IntoIteratorvia an&'areference to the respective collections (IArray,IMap).This means the iterator may not outlive the instance. For example, you may not return the iterator from a function, if the supplied
IArraydoes not outlive the function scope:The
IArrayimplementation is rewritten to the same approach for consistency. Breaking change.Closes #69 because the two approaches are disjoint.