Open
Conversation
Owner
|
I will review your pull request with great enthusiasm when I get the chance, thank you 😺 |
Owner
|
I've been focused on some other plugins for a couple of weeks and am still working on them so I still couldn't review the PR. Afterwards, I'll prioritize reviewing this. |
9924d3c to
bd5f3a3
Compare
Owner
|
We need to make sure that there aren't any edge cases with the text color modifications, for example when skin changes at runtime. I might ask you to only set the input fields' interactable to false and not touch the text color but I haven't decided yet. Please wait until #50 is merged. Even though that PR was created afterwards, it'll be easier to merge this PR to that one instead merging that PR to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for read-only fields. A drawer can be made read-only from outside, for example in a
IRuntimeInspectorCustomEditor, or via the newRuntimeInspectorReadonlyAttribute. This attribute can specify a static function, which is queried inInspectorField.Refresh()and returns whether the corresponding field or property should be rendered as read-only. If no function is supplied, members with this attribute are always considered read-only.Of course it would be nice to also link instance methods in the attribute, but this would necessitate further code changes, because:
MemberInfo(InspectorField.BindTo()) to get the attribute from, doesn't have access to the instance on which to search for the method.Let me know what you think about this implementation. If you are open for a merge, I'm happy to supply documentation.