Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crypto.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ func (s Signer) sign(buff []byte) ([]byte, error) {
return ecdsaSignRaw(rand.Reader, &key, hashed[:])
case "ed25519":
key := s.key.(ed25519.PrivateKey)
if len(key) != ed25519.PrivateKeySize {
return nil, fmt.Errorf("key must be %d bytes long", ed25519.PrivateKeySize)
}
return ed25519.Sign(key, buff), nil
default:
return nil, fmt.Errorf("sign: unknown algorithm \"%s\"", s.alg)
Expand Down
13 changes: 13 additions & 0 deletions crypto_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package httpsign

import (
"crypto/ed25519"
"crypto/rand"
"crypto/rsa"
"github.com/lestrrat-go/jwx/v2/jwa"
Expand Down Expand Up @@ -100,6 +101,18 @@ func TestSigner_sign(t *testing.T) {
want: nil,
wantErr: true,
},
{
name: "ed25519 key not 64 bytes",
fields: fields{
key: ed25519.PrivateKey(strings.Repeat("a", 63)),
alg: "ed25519",
},
args: args{
buff: []byte("abc"),
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down