Use Node 22 for GitHub actions for now #6575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemyan
force-pushed
the
clemyan/e2e/node22
branch
from
3914880 to
b56ef28
Compare
merceyz
approved these changes
Oct 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
1 task
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Jan 4, 2026
## What's the problem this PR addresses? Our CI are running against node versions that are not supported like 19. The version list is manually managed, meaning we need to update it each time Node releases new majors. Also, in #6575 we pinned node versions for most CI processes to Node 22 to avoid 23.0 shenanigans. ## How did you fix it? Add a step to fetch available Node versions and filter them down to major versions that are even-numbered and >=18, or the latest major. This needs to be updated only when we change our own supported Node versions. And essentially revert #6575 to use the current Node version ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
There are a number of issues affecting Node 23, causing our E2E suite and performance benchmarks to fail since its release:
nodejs/node#54224 (comment)
evanw/esbuild#3951
How did you fix it?
Drop down to Node 22 for those actions until the issues are cleared
Checklist