-
Notifications
You must be signed in to change notification settings - Fork 6
IsSensor type hints allow multidimensional channels #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-python into ddkohler-patch-1
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-python into ddkohler-patch-1
|
Not sure why pytest freezes from 3.12, ubuntu-latest; will look into when I get the chance. |
for more information, see https://pre-commit.ci
curious if the freze issue still persists
for more information, see https://pre-commit.ci
ksunden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the primary change here, I'd tend to prefer that python version stuff be changed independently if possible (just cleaner that way)
Nothing to worry about undoing, just a preference.
That said, 3.14 is out, so may be time to go through a lot of repos and update the python version systematically. (unrelated to this change though)
I think the original typing for
channel_shapedid not account for the possibility of multidimensional channels. This PR lets thetuplefor shape be any length ofints.Changes
tuple[int]->tuple[int, ...]MeasureType--I don't believe the current definition was accurate (it assumed all dict items were floats), and it is cumbersome to keep type alias definitions succinct, while adopting current type hint practices, across all supported python versions (python>=3.8).TODO
from __future__ import annotations)