Set cmake min version to represent used features.#2852
Merged
JohanMabille merged 2 commits intoxtensor-stack:masterfrom Jun 10, 2025
Merged
Set cmake min version to represent used features.#2852JohanMabille merged 2 commits intoxtensor-stack:masterfrom
JohanMabille merged 2 commits intoxtensor-stack:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The cmake minimum required version was set to 3.29, which is newer than what a lot of linux distros ship with, and was unnecessarily high for the cmake features that were being used. This PR drops the min version to 3.15 to reflect used features and improve out-of-the-box compatibility.
Closes #2847.