Merged
Conversation
This file was completely disabled and never included, and so not tested and broken. This patches fixes: * Missing include in the _isa.hpp * Typo in the include guard * Variable name within fast_cast * Requirements to avx512dq
degasus
commented
Jul 21, 2025
| #include "./xsimd_avx512f.hpp" | ||
| #endif | ||
|
|
||
| #if XSIMD_WITH_AVX512DQ |
Contributor
Author
There was a problem hiding this comment.
FYI: XSIMD_WITH_AVX512CD is missing as well. However it does not define anything, but might yield the same issue again.
Contributor
|
Thanks! |
Contributor
|
Interesting. I did the same changes here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was completely disabled and never included, and so not tested and broken.
This patches fixes:
I have to be honest: I have no clue if those implementations are correct. My patch "just" enables the previously dead code. Please see this PR more as a bug report than as a fully tested patch.
FYI: I've noticed this as
to_float(int64)was very slow on MSVC. Please see: https://gcc.godbolt.org/z/q3MMn3q69GCC is able to optimize xsimd's slow path to the single instruction in
-O2, MSVC was not so lucky...