Fix build with Clang for Windows#1145
Merged
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom Jul 26, 2025
Merged
Conversation
Contributor
Contributor
|
(and thanks for spotting this!) |
Clemoot
force-pushed
the
fix-clang-windows-build
branch
from
c784bd2 to
a2b1f99
Compare
Contributor
Author
|
I updated the changes, which in fact are way cleaner with your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to compile and use xsimd with Clang on Windows.
I just discovered that Clang for Windows doesn't define
__GNUC__but instead defines_MSC_VER. That makes the compiler choose a version ofXSIMD_INLINEthat it does not support.The only solution I found that do supports both platforms is by extending
#if defined(__GNUC__)with(defined(_MSC_VER) && defined(__clang__).