Skip to content

Call get_handler on Error class instead of module #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcalvert wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Call get_handler on Error class instead of module #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9708ab8
Call get_handler on Error class instead of module
jcalvert Apr 2, 2026
b0e2197
Make the memory leak test threshold more generous to avoid false posi…
jcalvert Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/test_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_get_handler
LibXML::XML::Error.reset_handler
end
if saved_handler.nil?
assert_nil(LibXML::XML::get_handler)
assert_nil(LibXML::XML::Error.get_handler)
else
assert_equal(LibXML::XML::Error.get_handler, saved_handler)
end
Expand Down
2 changes: 1 addition & 1 deletion test/test_writer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def test_string_writer_does_not_leak_memory
rss_by_round << rss
end

assert_operator(rss_by_round.last - rss_by_round[1], :<, 5_000)
assert_operator(rss_by_round.last - rss_by_round[1], :<, 10_000)
end

private
Expand Down
Loading