Add linux-loongarch64 make target, now that loongarch dockcross is available#725
Open
arrowd wants to merge 1 commit into
Open
Add linux-loongarch64 make target, now that loongarch dockcross is available#725arrowd wants to merge 1 commit into
arrowd wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the loongarch64 architecture by adding a new build target to the Makefile and a corresponding dockcross helper script. Review feedback identifies a duplicate function definition in the new script and outdated documentation comments that incorrectly refer to the ARMv7 architecture.
| fi | ||
| } | ||
|
|
||
| help:update-image() { |
Contributor
There was a problem hiding this comment.
The function help:update-image is defined twice in this script. This second definition (at line 45) corresponds to the update-script command and should be renamed to help:update-script to ensure the help system functions correctly.
Suggested change
| help:update-image() { | |
| help:update-script() { |
…ailable This is a follow-up to xerial#526
arrowd
force-pushed
the
loongarch64-dockcross
branch
from
94c50b8 to
0326fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #526