CI PR #8: Fix pre-commit checks

.github/workflows/main.yml

@@ -20,6 +20,19 @@ env:
   PIP_DISABLE_PIP_VERSION_CHECK: "1" # Reduce noise in logs
 
 jobs:
+  pre-commit:
+    env:
+      SKIP: pytest,pytype,no-commit-to-branch
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-python@v4
+      with:
+        python-version: 3.11
+    - uses: pre-commit/action@v3.0.1
+    - uses: pre-commit-ci/lite-action@v1.0.3
+      if: always()
+
   test:
     strategy:
       # See: https://github.com/xenserver/python-libs/pull/26#discussion_r1179482169

.pre-commit-config.yaml

@@ -37,7 +37,7 @@
 # https://github.com/dexpota/cheatsheets/blob/master/pre-commit
 exclude: "^tests/data"
 fail_fast: true
-default_stages: [commit]
+default_stages: [pre-commit]
 repos:
 -   repo: local
     hooks:
@@ -47,7 +47,7 @@ repos:
         types: [binary]
         language: fail
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
     -   id: no-commit-to-branch
         args: [--branch, master]
@@ -62,19 +62,29 @@ repos:
           - isort
 
 
+-   repo: https://github.com/pre-commit/pygrep-hooks
+    rev: v1.10.0  # Use the ref you want to point at
+    hooks:
+    # Enforce that `# type: ignore` annotations always occur with specific codes.
+    # Sample annotation: # type: ignore[attr-defined,name-defined]
+    -   id: python-check-blanket-type-ignore
+
+
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.10.0
+    rev: v1.13.0
     hooks:
     -   id: mypy
         additional_dependencies:
+        - pyfakefs
+        - pytest_httpserver
         - pytest-subprocess
         - types-mock
         - types-six
         - types-toml
 
 
 -   repo: https://github.com/rcmdnk/pyproject-pre-commit
-    rev: v0.1.9
+    rev: v0.3.4
     hooks:
     -   id: shellcheck
 
@@ -86,7 +96,7 @@ repos:
 
 
 -   repo: https://github.com/pycqa/pylint
-    rev: v2.17.4
+    rev: v3.3.1
     hooks:
     -   id: pylint
         args:
@@ -98,12 +108,16 @@ repos:
             ]
         log_file: ".git/pre-commit-pylint.log"
         additional_dependencies:
-        -   pyfakefs
+        -   setuptools
         -   six
         -   mock
         -   pandas
+        -   pyfakefs
         -   pytest_forked
+        -   pytest_httpserver
         -   toml
+
+
 -   repo: local
     hooks:
     -   id: pytype
@@ -114,24 +128,29 @@ repos:
         language: python
         language_version: python3.8
         require_serial: true
-        additional_dependencies: [pytype]
+        additional_dependencies:
+        - pytype
+        - pyfakefs
+        - pytest
+        - pytest_forked
+        - pytest_httpserver
+        - pytest_localftpserver
+        - pytest-subprocess
+
+
     -   id: pytest
         name: Check pytest unit tests pass
         types: [python]
         # entry: sh -c "pytest -x -rf --new-first --show-capture=all >/dev/tty"
-        entry: sh -c "tox -e py38-covcombine >/dev/tty"
+        entry: sh -c "tox >/dev/tty"
         verbose: true
         language: python
         require_serial: true
         pass_filenames: false
--   repo: https://github.com/pre-commit/pygrep-hooks
-    rev: v1.10.0  # Use the ref you want to point at
-    hooks:
-    # Enforce that `# type: ignore` annotations always occur with specific codes.
-    # Sample annotations: # type: ignore[attr-defined] # type: ignore[attr-defined,name-defined]
-    -   id: python-check-blanket-type-ignore
+
+
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
     -   id: trailing-whitespace
     -   id: end-of-file-fixer

pytype_runner.py

@@ -77,7 +77,7 @@ def run_pytype(command: List[str], branch_url: str, errorlog: TextIO, results):
     ok = True
     while ok:
         for key, _ in sel.select():
-            line = key.fileobj.readline()  # type: ignore
+            line = key.fileobj.readline()  # type: ignore[union-attr]
             if not line:
                 ok = False
                 break