Fix CuPy uint8 overflow and CUDA cubic NaN fallback#1064
Merged
brendancol merged 1 commit intomasterfrom Mar 24, 2026
Merged
Conversation
Two remaining gaps from issue #1054: 1. CuPy resampling paths lacked integer clipping, so cubic ringing on uint8 data could silently wrap (e.g. 260 -> 4). Both _resample_cupy_native and _resample_cupy now clip results before casting, matching the NumPy path. 2. The CUDA cubic kernel wrote nodata when any of the 16 neighbors was NaN. It now falls back to bilinear with weight renormalization, matching the CPU Numba JIT behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the two remaining CuPy/CUDA gaps from #1054:
_resample_cupy_nativeand_resample_cupy) now clip integer results before casting, preventing silent uint8 overflow wrapping from cubic ringing_resample_cubic_cuda) falls back to bilinear with weight renormalization when NaN neighbors are present, matching the CPU Numba JIT behaviorTest plan
test_reproject.pysuite passes (79/79)