Skip to content

test: skip yarn package manager test if not present#2397

Open
suveshmoza wants to merge 2 commits into
wxt-dev:mainfrom
suveshmoza:test/skip-yarn-test-if-not-present
Open

test: skip yarn package manager test if not present#2397
suveshmoza wants to merge 2 commits into
wxt-dev:mainfrom
suveshmoza:test/skip-yarn-test-if-not-present

Conversation

@suveshmoza

Copy link
Copy Markdown
Contributor

Overview

  • Skips yarn package manager test when yarn is not present.
  • Added isYarnInstalled util to check yarn presence.

Manual Testing

  1. Without yarn installed, run bun run --filter wxt test yarn
wxt test $ buildc --deps-only -- vitest
│ [5 lines elided]
│ 
│  RUN  v4.1.5 /Users/suveshmoza/oss/wxt/packages/wxt
│ 
│  ↓ src/core/package-managers/__tests__/yarn.test.ts (2 tests | 2 skipped)
│ 
│  Test Files  1 skipped (1)
│       Tests  2 skipped (2)
│    Start at  15:49:37
│    Duration  118ms (transform 10ms, setup 10ms, import 13ms, tests 0ms, environment 0ms)
└─ Done in 470 ms
  1. With yarn installed, run bun run --filter wxt test yarn
wxt test $ buildc --deps-only -- vitest
│ [5 lines elided]
│ 
│  RUN  v4.1.5 /Users/suveshmoza/oss/wxt/packages/wxt
│ 
│  ✓ src/core/package-managers/__tests__/yarn.test.ts (2 tests) 246ms
│ 
│  Test Files  1 passed (1)
│       Tests  2 passed (2)
│    Start at  15:50:48
│    Duration  852ms (transform 10ms, setup 10ms, import 501ms, tests 246ms, environment 0ms)
└─ Done in 1.16 s

This PR closes #2371

@suveshmoza suveshmoza requested a review from aklinker1 as a code owner May 29, 2026 10:22
@netlify

netlify Bot commented May 29, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 8000051
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a207697a5a4d40008da786c
😎 Deploy Preview https://deploy-preview-2397--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label May 29, 2026
@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.60%. Comparing base (7905cb3) to head (8000051).

Files with missing lines Patch % Lines
packages/wxt/src/core/package-managers/yarn.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   78.46%   78.60%   +0.13%     
==========================================
  Files         133      133              
  Lines        3882     3888       +6     
  Branches      875      876       +1     
==========================================
+ Hits         3046     3056      +10     
+ Misses        749      746       -3     
+ Partials       87       86       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented May 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2397

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2397

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2397

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2397

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2397

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2397

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2397

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2397

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2397

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2397

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2397

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2397

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2397

wxt

npm i https://pkg.pr.new/wxt@2397

commit: 8000051

@suveshmoza suveshmoza force-pushed the test/skip-yarn-test-if-not-present branch from 5871476 to 8000051 Compare June 3, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 tests for yarn doesn't pass on windows by default

2 participants