fix(scripts): fix recognize lack of argument for scripts#2015
Open
PatrykKuniczak wants to merge 5 commits intowxt-dev:mainfrom
Open
fix(scripts): fix recognize lack of argument for scripts#2015PatrykKuniczak wants to merge 5 commits intowxt-dev:mainfrom
PatrykKuniczak wants to merge 5 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PatrykKuniczak
changed the title
void warnings of fs-extra(readFile, writeFile)void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts
PatrykKuniczak
force-pushed
the
fix/warnings-and-errors-of-scripts
branch
from
358bfe1 to
3be4972
Compare
5 tasks
PatrykKuniczak
changed the title
void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts
Contributor
Author
|
Sorry for a little mess, i haven't checked rest of the code for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I fixed check for no argument for scripts
which don't work(because if user don't type nothing
undefinedis returnwith
which works :)
And i cleaned code a little, of unnecessary console.log()
Manual Testing
Try to use all of those scripts without argument.