Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Sep 18, 2025

Description

Various snag fixes for:

  • Admin filters not showing selected filter
  • Offer the ability to not log the SeedQuery for Faust or typename
  • Some of the context logs are too large due to the response being logged. We should make this optional.
  • The config for filters isn't working
  • Pub/Sub not passing through level value
  • We shouldn't delete the database etc when we de-activate the plugin
  • Clear all button for filters

Note

Not all items have been addressed and we will create follow on issues for upcoming sprints.

Related Issue

#411

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: 04879e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wpgraphql-logging-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

ℹ️ Download the latest wpgraphql-logging plugin zip from this PR
(See the 'Artifacts' section at the bottom)

Added documentation and code to support optional database cleanup on plugin deactivation via the WP_GRAPHQL_LOGGING_UNINSTALL_PLUGIN constant. Updated admin settings field labels for clarity in the Basic Configuration tab.
@colinmurphy colinmurphy changed the title chore: DRAFT - WP GraphQL Logging Snags chore: WP GraphQL Logging Snags Sep 18, 2025
@colinmurphy colinmurphy marked this pull request as ready for review September 18, 2025 17:51
@colinmurphy colinmurphy requested a review from a team as a code owner September 18, 2025 17:51
@github-actions
Copy link

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ wpgraphql-logging.zip

See the "Artifacts" section at the bottom of the Actions run page

@colinmurphy colinmurphy added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit d0281d9 Sep 22, 2025
21 checks passed
@colinmurphy colinmurphy deleted the chore-wpgraphql-logging-snags-sept-2025 branch September 22, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants