Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Sep 11, 2025

Description

This solves the following

  1. Adds manage_option check for the settings page
  2. Updates the README.md
  3. Added fixes for running tests for WP 6.8

Related Issue

Fixes #380
Fixes #209

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

Updated Settings_Page::init() to require both is_admin() and current_user_can('manage_options'). Added and updated unit tests to verify correct behavior for users with and without the required capability.
Improved grammar, clarified feature descriptions, corrected file tree formatting, and updated example links for better guidance. Enhanced instructions and configuration details for easier understanding and setup.
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 59882a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/hwp-previews-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy marked this pull request as ready for review September 11, 2025 19:27
@colinmurphy colinmurphy requested a review from a team as a code owner September 11, 2025 19:27
@colinmurphy colinmurphy changed the title Chore Previews minor updates chore Previews minor updates Sep 11, 2025
@colinmurphy colinmurphy changed the title chore Previews minor updates chore: Previews minor updates Sep 11, 2025
Fixes adhoc applied for #389
…ngine/hwptoolkit into chore-hwp-previews-updates-sept-2025
@colinmurphy colinmurphy added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit 1dbc036 Sep 12, 2025
21 checks passed
@colinmurphy colinmurphy deleted the chore-hwp-previews-updates-sept-2025 branch September 12, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Previews admin should check for user capabilities when managing settings chore: Update HWP Previews README

3 participants