Skip to content

chore: Fixes for Github Actions for code quality and tests. #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colinmurphy merged 26 commits into from
Sep 2, 2025
Merged

chore: Fixes for Github Actions for code quality and tests. #395

colinmurphy merged 26 commits into from
Sep 2, 2025

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Sep 1, 2025 •
edited
Loading

Description

This PR fixes issues for #381 and uses the wpgraphql-logging plugin to test this (while also fixing some code quality errors).

This does the following

  1. Fixes typo for code quality checkes
  2. Fixes code quality issues for Logging
  3. Fixed SSL issue for WordPress 6.8 for logging (should be applied to other plugins once merged)

Related Issue

Fixes #381

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1c3ab56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

ℹ️ Download the latest wpgraphql-logging plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy
Update output references in code quality workflow
81b68f6 
Changed output variable references from 'detect' to 'detect-plugin-slug' in the code quality GitHub Actions workflow to ensure correct step outputs are used.
@colinmurphy
Fix SSL issue for running tests on WordPress 6.8 for the logging plugin.
3ea7815
@colinmurphy colinmurphy changed the title DRAFT: Fix Github Actions fix: DRAFT Fix Github Actions Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy mentioned this pull request Sep 1, 2025
Closed
@colinmurphy
Fixed PHPStan errors for logging.
323c844
@colinmurphy
Fixed PHPCS errors for the logging plugin.
eb60091
@colinmurphy
Fixed Psalm errors for the logging plugin.
e3e7ec0
@colinmurphy
Reverted changes so I can just test logging plugin.
cbdfe65
@colinmurphy
Fixed fatal error caused by code quality change.
bba0c2c
@colinmurphy
Removed test file as it needs to be fixed a later iteration.
963b9f7
@colinmurphy
Fixing SSL issue in the docker-compose file.
d7e1b1f
@colinmurphy
Reverting changes.
9f9c350
@colinmurphy
Adding a fix fir SSL for tests.
0680088
@colinmurphy
Updating docker compose file to fix the issue for 6.8 with SSL required.
eb22341
@colinmurphy
Updating mysql commands to disable SSL mode.
466d4f9
@colinmurphy
Updated mariaDB version to fix issue with --ssl-mode=DISABLED
0629d98
@colinmurphy
Fix for docker-compose.
23abea6
@colinmurphy
Added healthcheck.
d75c12c
@colinmurphy
Fixes.
5525b94
@colinmurphy
Reverting mariadb change.
c35849a
@colinmurphy
Reverted. Added mu plugin to see if we can disable WP SSL verify.
0202479
@colinmurphy
Adding --no-defaults to try and ignore SSL issue.
b7b6f47
@colinmurphy
Fixing SSL flag.
d65c247
@colinmurphy colinmurphy changed the title fix: DRAFT Fix Github Actions chore: Fixes for Github Actions for code quality and tests. Sep 2, 2025
@colinmurphy colinmurphy marked this pull request as ready for review September 2, 2025 09:47
@colinmurphy colinmurphy requested a review from a team as a code owner September 2, 2025 09:47
@colinmurphy colinmurphy added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit aeb24b2 Sep 2, 2025
30 checks passed
@colinmurphy colinmurphy deleted the chore-github-action-fixes-sept-2025 branch September 2, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theodesp theodesp theodesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HWP Toolkit: Github Actions various bugs

3 participants

@colinmurphy @theodesp