Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Jul 10, 2025

Description

  1. Disables Faust front-end redirects for preview url's to solve the iframe conflict.
  2. Introduced methods in Faust_Integration to replace Faust-generated preview URLs with the site’s home URL as needed.

Related Issue

Dependant PRs

N/A

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Manually, E2E, PHP test suite

Screenshots

N/A

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: f838634

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/hwp-previews-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@ahuseyn ahuseyn linked an issue Jul 10, 2025 that may be closed by this pull request
@ahuseyn ahuseyn marked this pull request as ready for review July 10, 2025 15:24
@ahuseyn ahuseyn requested a review from a team as a code owner July 10, 2025 15:24
colinmurphy
colinmurphy previously approved these changes Jul 10, 2025
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuseyn

LGTM 🚀 🚀 🚀

Co-authored-by: Colin Murphy <colinmurphy@users.noreply.github.com>
@ahuseyn ahuseyn requested a review from colinmurphy July 11, 2025 09:45
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuseyn Looks amazing 🚀 🚀 🚀

@ahuseyn ahuseyn added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit 61de798 Jul 11, 2025
19 checks passed
@ahuseyn ahuseyn deleted the fix-hwp-previews-faust-iframe-conflict branch July 11, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(previews): Handle Faust frontend URL-HWP Previews iframe conflict

3 participants