Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jul 2, 2025

Description

  1. Renames our composer package to composer-packages.json instead of package.json (thanks @theodesp for pointing this out that it is like npm package file name)
  2. Fixes issues with failing workflows when a branch is merged into main as it has no base sha for the pull request. This has a knock on effect of making our badges for plugins fail.
  3. Fixes workflows for code quality etc to run off plugin sub-directory changes not plugin changes e.g. plugins/composer-packages.json should not trigger a e2e test workflow.

Related Issue

#303

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

…uest sha so the process fails and causes our badges to fail too.
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: bb3bb2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy marked this pull request as ready for review July 2, 2025 12:49
@colinmurphy colinmurphy requested a review from a team as a code owner July 2, 2025 12:49
@colinmurphy colinmurphy added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit f7b37b8 Jul 2, 2025
19 checks passed
@colinmurphy colinmurphy deleted the chore-fix-composer-package-file branch July 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants