Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jun 27, 2025

Description

This solves a few issues

  1. Splits code quality and testing integration into 2 steps
  2. The first step is to check that the plugin has configuration files required to run the checks/tests
  3. Instead of failing the whole action, we only run step 2 (code quality checks, tests) if they have the correct configuration
  4. We also create specific actions so we can use these for badges

Outcomes are:

  1. Reduces checks for plugins which might not have these checks/steps setup
  2. Run plugin specific actions e.g. "hwp-previews php code quality checks"
  3. We can then use this for each plugin

e.g.

[![Testing Integration](https://img.shields.io/github/check-runs/wpengine/hwptoolkit/main?checkName=hwp-previews%20codeception%20tests&label=Automated%20Tests)](https://github.com/wpengine/hwptoolkit/actions)

[![Code Quality](https://img.shields.io/github/check-runs/wpengine/hwptoolkit/main?checkName=hwp-previews%20php%20code%20quality%20checks&label=Code%20Quality%20Checks)](https://github.com/wpengine/hwptoolkit/actions)

Screenshot 2025-06-27 at 12 50 15

Related Issue

Fixes #286

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

…ill skip the code quality check if phpcs.xml does not exist.
@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: e92d283

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/hwp-previews-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy changed the title chore: DRAFT Updating workflows chore: Updating workflows for code quality and testing integration Jun 27, 2025
@colinmurphy colinmurphy marked this pull request as ready for review June 27, 2025 11:57
@colinmurphy colinmurphy requested a review from a team as a code owner June 27, 2025 11:57
@colinmurphy colinmurphy enabled auto-merge June 27, 2025 11:57
@colinmurphy colinmurphy added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 4b9af17 Jun 27, 2025
31 checks passed
@colinmurphy colinmurphy deleted the chore-split-code-quality-test-workflow-to-skip-rather-than-fail branch June 27, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Fixing workflows to skp rather than fail

3 participants