Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Jun 17, 2025

Description

URI parameter leads to misunderstandings (missing in draft posts) and bugs (#201) and adds little to no value the actual functionality. Unless explicitly requested we don't need to keep it.

Related Issue

Dependant PRs

N/A

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Manually, E2E

Screenshots

N/A

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@ahuseyn ahuseyn requested a review from a team as a code owner June 17, 2025 09:46
@ahuseyn ahuseyn requested a review from colinmurphy June 17, 2025 09:46
@github-actions
Copy link

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@ahuseyn ahuseyn linked an issue Jun 17, 2025 that may be closed by this pull request
@colinmurphy colinmurphy added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 5f5a2be Jun 17, 2025
16 checks passed
@colinmurphy colinmurphy deleted the previews-remove-uri-tag branch June 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(previews): Previews {URI} template doesn't follow permalinks

3 participants