Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jun 16, 2025

Description

Closes #192

  • Finishes out unit tests (over 95% code coverage)
  • Adjusts some of the GH workflows to only run when the plugin is setup for these (e.g. tests need a codeception.dist.yml file)

Related Issue

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

…tion and added tests for unit as we already have e2e tests
…ests to be able to test most of the functionality.
@ahuseyn
Copy link
Member

ahuseyn commented Jun 24, 2025

@colinmurphy I've pushed a commit to add e2e test for the URL validation case #243

@colinmurphy
Copy link
Member Author

Ah perfect. Thanks @ahuseyn :) ❤️

@colinmurphy colinmurphy changed the title chore: DRAFT - Preview Unit Tests - Iteration 2 chore: Preview Unit Tests - Iteration 2 Jun 24, 2025
@colinmurphy colinmurphy marked this pull request as ready for review June 24, 2025 15:48
@colinmurphy colinmurphy requested a review from a team as a code owner June 24, 2025 15:48
@colinmurphy colinmurphy enabled auto-merge June 24, 2025 15:48
@colinmurphy colinmurphy requested a review from ahuseyn June 24, 2025 15:49
ahuseyn
ahuseyn previously approved these changes Jun 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 8d8e67f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ahuseyn ahuseyn self-requested a review June 25, 2025 08:11
@colinmurphy colinmurphy added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 53b1482 Jun 25, 2025
16 checks passed
@colinmurphy colinmurphy deleted the chore-phpunit-tests-previews-iteration-2 branch June 25, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Add phpunit test suite to the plugin

3 participants