Light updates to the install-wp-tests.sh script#356
Open
swissspidy wants to merge 37 commits intomainfrom
Open
Light updates to the install-wp-tests.sh script#356swissspidy wants to merge 37 commits intomainfrom
install-wp-tests.sh script#356swissspidy wants to merge 37 commits intomainfrom
Conversation
1 task
GaryJones
reviewed
Oct 6, 2025
templates/install-wp-tests.sh
Outdated
| if [[ $1 =~ ^(y|yes)$ ]] | ||
| then | ||
| mysqladmin drop $DB_NAME -f --user="$DB_USER" --password="$DB_PASS"$EXTRA | ||
| if [ `which mariadb-admin` ]; then |
Contributor
There was a problem hiding this comment.
Just because MariaDB might exist locally, is that sufficient to know that the developer wants to use it?
Member
Author
There was a problem hiding this comment.
We could allow overriding with a flag perhaps if needed.
|
Nice update! Moving to GIT that is better supported. |
GaryJones
reviewed
Oct 7, 2025
Co-authored-by: Gary Jones <gamajo@gamajo.com>
This comment was marked as resolved.
This comment was marked as resolved.
Incorporating changes from #346
1 task
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
- Modified download() to return error codes from curl/wget - Updated check_for_updates() to check download() return value - Added validation for empty downloaded files using -s flag - Improved error messaging to distinguish between network failures and empty files Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
1 task
swissspidy
commented
Jan 25, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by some changes in some of my own project, this PR modernizes the
install-wp-tests.shscript with several improvements including migration from SVN to GitHub for downloading WordPress core and test files, addition of colored output, automatic update checking, and MariaDB support.Changes:
Related:
install-wp-tests.shscript #322