Ensure $assoc_args can be used in eval

[swissspidy]

Fixes a regression introduced with the closure approach in #84

[github-actions]

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

• composer install: Install dependencies.
• composer test: Run the full test suite.
• composer phpcs: Check for code style violations.
• composer phpcbf: Automatically fix code style violations.
• composer phpunit: Run unit tests.
• composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical regression in the wp eval command, restoring the intended functionality for associative arguments. Previously, a change involving closures inadvertently prevented $assoc_args from being accessible within the evaluated code. The fix ensures that these arguments are correctly captured and available, thereby resolving the issue and maintaining expected behavior for users relying on wp-cli.yml configurations with eval.

Highlights

• Regression Fix: Resolved a regression where associative arguments ($assoc_args) were not correctly passed into the eval context within the wp eval command, which was introduced by a previous closure-based change.
• Argument Accessibility: Ensured that the $assoc_args variable is properly captured by the execute_closure and made available for use within the evaluated PHP code.
• New Test Case: Added a new Behat scenario to verify that associative arguments defined in wp-cli.yml are accessible when running wp eval.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request fixes a regression in the wp eval command, making $assoc_args available to the executed code again. This is achieved by passing the variable into the execution closure. A corresponding feature test has been added to verify the functionality. The change correctly resolves the described issue.

[Copilot]

Pull request overview

Fixes a regression introduced by the deferred-execution closure approach (from #84) where $assoc_args was no longer available to code executed via wp eval, especially when deferred to a WordPress hook.

Changes:

• Capture $assoc_args in the wp eval execution closure so evaluated code can access it.
• Add a Behat scenario asserting $assoc_args is available (including args provided via wp-cli.yml).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Eval_Command.php	Captures $assoc_args into the eval closure so evaluated code can reference it reliably.
features/eval.feature	Adds a regression test ensuring $assoc_args is accessible from wp eval code.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.