Skip to content

Add automatic --silent flag to mysqlcheck commands when --quiet is set #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+83 −1
Draft

Add automatic --silent flag to mysqlcheck commands when --quiet is set #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
237d08f
Initial plan
Copilot Jan 12, 2026
0814b9c
Add --quiet support for db check, optimize, and repair commands
Copilot Jan 12, 2026
73aad75
Move tests
swissspidy Jan 13, 2026
1a36bab
Update test
swissspidy Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions features/db-check.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,25 @@ Feature: Check the database
Success: Database checked.
"""

Scenario: db check with --quiet flag should only show errors
Given a WP install

When I run `wp db check --quiet`
Then STDOUT should be empty

Scenario: db check can explicitly pass --silent to mysqlcheck
Given a WP install

When I run `wp db check --silent`
Then STDOUT should not contain:
"""
wp_cli_test.wp_users
"""
And STDOUT should contain:
"""
Success: Database checked.
"""

Scenario: Run db check with MySQL defaults to check the database
Given a WP install

Expand Down
47 changes: 46 additions & 1 deletion features/db.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,51 @@ Feature: Perform database operations
"""
And STDOUT should not be empty

Scenario: db optimize with --quiet flag should only show errors
Given a WP install

When I run `wp db optimize --quiet`
Then STDOUT should not contain:
"""
error
"""


Scenario: db optimize can explicitly pass --silent to mysqlcheck
Given a WP install

When I run `wp db optimize --silent`
Then STDOUT should not contain:
"""
error
"""
And STDOUT should contain:
"""
Success: Database optimized.
"""

Scenario: db repair with --quiet flag should only show errors
Given a WP install

When I run `wp db repair --quiet`
Then STDOUT should not contain:
"""
error
"""

Scenario: db repair can explicitly pass --silent to mysqlcheck
Given a WP install

When I run `wp db repair --silent`
Then STDOUT should not contain:
"""
error
"""
And STDOUT should contain:
"""
Success: Database repaired.
"""

Scenario: DB Query
Given a WP install

Expand Down Expand Up @@ -334,7 +379,7 @@ Feature: Perform database operations
"""
Query succeeded. Rows affected: 1
"""

When I run `wp db query "SELECT * FROM wp_users WHERE ID = 1"`
Then STDOUT should not contain:
"""
Expand Down
18 changes: 18 additions & 0 deletions src/DB_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ public function check( $_, $assoc_args ) {
WP_CLI::debug( "Running shell command: {$command}", 'db' );

$assoc_args['check'] = true;

// Pass --silent to mysqlcheck when in quiet mode.
if ( WP_CLI::get_config( 'quiet' ) ) {
$assoc_args['silent'] = true;
}

self::run(
Utils\esc_cmd( $command, DB_NAME ),
$assoc_args
Expand Down Expand Up @@ -307,6 +313,12 @@ public function optimize( $_, $assoc_args ) {
WP_CLI::debug( "Running shell command: {$command}", 'db' );

$assoc_args['optimize'] = true;

// Pass --silent to mysqlcheck when in quiet mode.
if ( WP_CLI::get_config( 'quiet' ) ) {
$assoc_args['silent'] = true;
}

self::run(
Utils\esc_cmd( $command, DB_NAME ),
$assoc_args
Expand Down Expand Up @@ -355,6 +367,12 @@ public function repair( $_, $assoc_args ) {
WP_CLI::debug( "Running shell command: {$command}", 'db' );

$assoc_args['repair'] = true;

// Pass --silent to mysqlcheck when in quiet mode.
if ( WP_CLI::get_config( 'quiet' ) ) {
$assoc_args['silent'] = true;
}

self::run(
Utils\esc_cmd( $command, DB_NAME ),
$assoc_args
Expand Down
Loading