Skip to content

Fix tests#134

Merged
swissspidy merged 4 commits intomainfrom
try/fix-tests
Mar 17, 2026
Merged

Fix tests#134
swissspidy merged 4 commits intomainfrom
try/fix-tests

Conversation

@swissspidy
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix to ensure the correct filtering of cron events. Specifically, it modifies the get_selected_cron_events function to properly pass the $due_now argument to the underlying get_cron_events method, which is crucial for accurate event processing and resolving related test failures.

Highlights

  • Cron Event Filtering: The get_cron_events method call was updated to correctly pass the $due_now parameter, ensuring that cron events are filtered as intended.
Changelog
  • src/Cron_Event_Command.php
    • Passed the $due_now parameter to the get_cron_events method call.
Activity
  • No activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the get_selected_cron_events function to pass the $due_now flag to get_cron_events. This enables an optimization on WordPress 5.1+ by using the more efficient wp_get_ready_cron_jobs() function to fetch only cron events that are due, rather than fetching all events and filtering them. The change is logical and improves performance for commands using the --due-now flag. The implementation is correct and I have no suggestions for improvement.

@swissspidy

This comment was marked as resolved.

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Cron_Event_Command.php 90.90% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

* Initial plan

* Fix unschedule for WP 4.9 compatibility

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
@swissspidy swissspidy marked this pull request as ready for review March 17, 2026 07:20
@swissspidy swissspidy requested a review from a team as a code owner March 17, 2026 07:20
Copilot AI review requested due to automatic review settings March 17, 2026 07:20

This comment was marked as resolved.

swissspidy and others added 2 commits March 17, 2026 08:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@swissspidy swissspidy merged commit 8460962 into main Mar 17, 2026
60 checks passed
@swissspidy swissspidy deleted the try/fix-tests branch March 17, 2026 08:37
@swissspidy swissspidy added this to the 2.3.5 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants