fix: properly separate static pages from Vite-built React pages #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move React HTML entry points (dashboard, admin, pull_request) to root - Remove old root index.html (Vite shell) - landing page is in public/ - Configure Vite with multi-page rollupOptions.input for React pages only - Set publicDir: false so Vite doesn't interfere with public/ folder - Update server to serve static files from public/, React from dist/ - Fix HTML files to use consistent script/css references Architecture: - public/ contains static pages (landing, imprint, privacy) served directly - Root HTML files are Vite entry points, built to dist/ - In production: static from public/, React pages from dist/ - In development: Vite middleware transforms React pages on the fly
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2026-01-19 at 13:06:04 UTC (today) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2026-01-18, 07:06:11 - Pull request opened This comment is automatically updated by worlddriven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the webapp to properly serve the landing page instead of the Vite React shell.
Problem
The webapp was serving the Vite build output (
dist/index.html- "Worlddriven Admin") instead of the actual landing page (public/index.html).Solution
Properly separate static pages from Vite-processed React pages:
Static pages (served directly from
public/):index.html)React pages (Vite entry points, built to
dist/):Changes
rollupOptions.inputfor multi-page apppublicDir: falseso Vite doesn't copy/overwrite public filespublic/, React fromdist/Architecture
Test Plan