Show a flat list of hierarchical list depending on pages count#25376
Show a flat list of hierarchical list depending on pages count#25376crazytonyli merged 1 commit intotrunkfrom
Conversation
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31464 | |
| Version | PR #25376 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9c9dd80 | |
| Installation URL | 100deuh0q0tbg |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31464 | |
| Version | PR #25376 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9c9dd80 | |
| Installation URL | 6a5uuhc46na80 |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
| endpointType: details.toPostEndpointType(), | ||
| filter: filter.asPostListFilter(), | ||
| perPage: 20 | ||
| perPage: 100 |
There was a problem hiding this comment.
This change causes an error, which is fixed in #25360.
There was a problem hiding this comment.
I'm just wondering if you tried different options to see which one is the most efficient? 20 seemed a bit low.
There was a problem hiding this comment.
I did not notice any slowness in loading posts when using 100. Any specific tests you want to try?
kean
left a comment
kean
left a comment
There was a problem hiding this comment.
Thank you, that should work. I'd probably go a step further and limit it to 100 – one page. It should make the implementation a bit simpler too.
| endpointType: details.toPostEndpointType(), | ||
| filter: filter.asPostListFilter(), | ||
| perPage: 20 | ||
| perPage: 100 |
There was a problem hiding this comment.
I'm just wondering if you tried different options to see which one is the most efficient? 20 seemed a bit low.
4 participants
Description
Previously, the app always fetches all the pages (or post supports hierarchy). This PR adds a threshold (200). The app now fetches all posts and displays a hierarchical list, if the total post count is less than the threshold. Otherwise, it displays a flat list as if the post does not support hierarchy.