Skip to content

Make SharedDataIssueSolver a non-objc type #25295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 1 commit into from
Feb 25, 2026
Merged

Make SharedDataIssueSolver a non-objc type #25295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/WordPressData/Swift/AuthKeyMigration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ public struct AuthKeyMigration: AuthKeyMigrationProtocol {
return true
}
guard shouldMigrate else { return }
SharedDataIssueSolver.instance().migrateAuthKey(for: username)
SharedDataIssueSolver().migrateAuthKey(for: username)
}
}
10 changes: 1 addition & 9 deletions Sources/WordPressData/Swift/SharedDataIssueSolver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import WordPressShared
import BuildSettingsKit

@objcMembers
public final class SharedDataIssueSolver: NSObject {
public final class SharedDataIssueSolver {

private let contextManager: CoreDataStack
private let keychainUtils: KeychainUtils
Expand All @@ -22,13 +21,6 @@ public final class SharedDataIssueSolver: NSObject {
self.appGroupName = appGroupName
}

/// Helper method for creating an instance in Obj-C
///
@objc
public class func instance() -> SharedDataIssueSolver {
return SharedDataIssueSolver()
}

public func migrateAuthKey() {
guard let account = try? WPAccount.lookupDefaultWordPressComAccount(in: contextManager.mainContext) else {
return
Expand Down